Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow *.xml (beside *.log) files as sample input files #550

Merged
9 commits merged into from
Feb 28, 2022

Conversation

hsekowski-splunk
Copy link
Contributor

No description provided.

@hsekowski-splunk
Copy link
Contributor Author

This PR is to address #549

@hsekowski-splunk hsekowski-splunk marked this pull request as ready for review February 18, 2022 07:49
@hsekowski-splunk hsekowski-splunk requested review from a user and nandinivij February 18, 2022 07:49
@ghost
Copy link

ghost commented Feb 18, 2022

I think it is a good one, @nandinivij WDYT?

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this line

? Do we need to change this?

And I would like to see a docker-based test that confirms that this feature works.

@hsekowski-splunk
Copy link
Contributor Author

@arys-splunk ,
Good catch and valid question - yes, better to have the data ingested :)

@ghost
Copy link

ghost commented Feb 18, 2022

@hsekowski-splunk Can you please also change the target branch to develop?

@hsekowski-splunk hsekowski-splunk changed the base branch from main to develop February 18, 2022 13:58
@nandinivij
Copy link
Contributor

We will need changes unit test side too. Currently, we generate errors for anything other than .log and do not run prerequisite tests for that.

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2022

Codecov Report

Merging #550 (6fb6702) into develop (4dc506e) will decrease coverage by 0.41%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #550      +/-   ##
===========================================
- Coverage    95.13%   94.72%   -0.42%     
===========================================
  Files           49       42       -7     
  Lines         2613     2557      -56     
===========================================
- Hits          2486     2422      -64     
- Misses         127      135       +8     
Impacted Files Coverage Δ
...unk_addon/standard_lib/addon_requirements_basic.py 0.00% <0.00%> (ø)
...n/standard_lib/requirement_tests/test_generator.py 70.98% <75.00%> (-0.09%) ⬇️
..._lib/event_ingestors/requirement_event_ingester.py 54.25% <100.00%> (ø)
..._tests/requirement_test_datamodel_tag_constants.py 0.00% <0.00%> (-100.00%) ⬇️
...on/standard_lib/sample_generation/sample_stanza.py 97.22% <0.00%> (-1.40%) ⬇️
...ddon/standard_lib/addon_parser/eventtype_parser.py 96.15% <0.00%> (-0.28%) ⬇️
.../standard_lib/addon_parser/savedsearches_parser.py 96.87% <0.00%> (-0.19%) ⬇️
...don/standard_lib/addon_parser/transforms_parser.py 97.10% <0.00%> (-0.09%) ⬇️
...nk_addon/standard_lib/addon_parser/props_parser.py 99.20% <0.00%> (-0.02%) ⬇️
...plunk_addon/standard_lib/sample_generation/rule.py 99.34% <0.00%> (-0.01%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23deab5...6fb6702. Read the comment docs.

@github-actions
Copy link
Contributor

Expected release notes (by @hsekowski-splunk)

features:
remove splunk-appinspect dependency (#499) (a56e9d1)
allow *.xml (beside *.log) files as sample input files (b2b3596)

fixes:
ingestion extended by *.xml files (0147b5e)
fake_path corrected for xml sample (85226b4)
unit test addopted to the change (85717f6)

others (will not be included in Semantic-Release notes):
assertion updated (6fb6702)
assertion changed to reflect second source of the data that causes additional successful pass (e2c3f68)
add *.xml file to requirement tests (c01b8eb)
update development instructions (#564) (5071ddb)
reorganize how doc are being handled in CI (#563) (330a0cb)
remove pytest-mock as not used (#560) (04cb76c)
fix semgrep issues (#558) (6c8bb63)
remove Ederson from owners list [ci skip] (#559) (278bfdd)
make tests run in parallel (#553) (acfddc8)
updated error msg (5ffe040)
move test_cim_report.py to unit tests (#554) (43365bf)
add pyupgrade and isort to pre-commit (#552) (5acb649)
clean up helmut after initial refactoring (#544) (eb940bc)
3.0.0-beta.1 (d17c293)
to test the project unit tests (3ccf59c)
remove test_events_with_untokenised_values from RequirementBasic (#543) (23deab5)
remove matrix option from test-splunk-matrix step (#545) (5464510)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@ghost ghost merged commit 01651e9 into develop Feb 28, 2022
@ghost ghost deleted the feat/accept_xml_as_samples_for_req_tests branch February 28, 2022 14:34
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants