Add connectFilter mixin #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar in usage to the `connect` mixin except it allows you to pass in a filterFunction to filter items from your store before they get passed on.
|
👍 |
|
Thanks! |
| var PostView = React.createClass({ | ||
| mixins: [Reflux.connectFilter(postStore,"post", function(posts) { | ||
| posts.filter(function(post) { | ||
| post.id === this.props.id; |
There was a problem hiding this comment.
am I wrong or are one or two return statements missing here?
There was a problem hiding this comment.
Yup... nice catch.
I've been having too much coffeescript lately to notice. 👍
There was a problem hiding this comment.
Heh, that was my problem too.
On Mon, Feb 16, 2015 at 11:25 PM Mikael Brassman notifications@github.com
wrote:
In README.md
#222 (comment):@@ -501,6 +501,27 @@ var Status = React.createClass({
});+#### Using Reflux.connectFilter + +`Reflux.connectFilter` is used in a similar manner to `Reflux.connect`. Use the +`connectFilter` mixin when you want only a subset of the items in a store. A +blog written using Reflux would probably have a store with all posts in +it. For an individual post page, you could use `Reflux.connectFilter` to +filter the posts to the post that's being viewed. + +```javascript +var PostView = React.createClass({ + mixins: [Reflux.connectFilter(postStore,"post", function(posts) { + posts.filter(function(post) { + post.id === this.props.id;Yup... nice catch.
I've been having too much coffeescript lately to notice. [image: 👍]
—
Reply to this email directly or view it on GitHub
https://github.com/spoike/refluxjs/pull/222/files#r24797357.
There was a problem hiding this comment.
seems to be fixed now by #240
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar in usage to the
connectmixin except it allows you to pass ina filterFunction to filter items from your store before they get passed
on.