Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make argument parsing fail on unknown parameters #62

Open
egpbos opened this issue Jan 13, 2021 · 0 comments
Open

Make argument parsing fail on unknown parameters #62

egpbos opened this issue Jan 13, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@egpbos
Copy link
Collaborator

egpbos commented Jan 13, 2021

Currently, our custom config class does not fail when it encounters unknown parameters. This is mostly a legacy from the past in which we were using multiple parsing moments. Currently, the parse_unknown_args function is still used to do some complicated help-print delaying. I don't think we still need that either. So let's just switch to parse_args so that the parser automatically checks for faulty arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant