Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VillagerFactory redundant #337

Closed
Skepfyr opened this issue Dec 28, 2014 · 4 comments
Closed

VillagerFactory redundant #337

Skepfyr opened this issue Dec 28, 2014 · 4 comments

Comments

@Skepfyr
Copy link
Contributor

Skepfyr commented Dec 28, 2014

From what I can see the VillagerFactory class is useless as all the functionality it provides is also provided by GameRegistry and Career.
@ST-DDT
Copy link
Member

ST-DDT commented Dec 29, 2014

AIOOB is right here, the villager factory has only methods that are already covered by other classes/interfaces so it should be removed.
The other alternative would be removing the methods from the GameRegistry, but this has the drawback of an inconsistent API, so i prefer removing the factory.

@gabizou
Copy link
Member

gabizou commented Jan 5, 2015

If we are to remove VillagerFactory, then LivingMetaFactory would be removed as well, just in case you haven't considered that ramification as well.

@ST-DDT
Copy link
Member

ST-DDT commented Jan 5, 2015

I dont see any benefits for this class/interface either.

@stephan-gh
Copy link
Contributor

This was fixed in e8c307a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sk89q @gabizou @ST-DDT @stephan-gh @Skepfyr