Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map types #66

Merged
merged 3 commits into from Mar 20, 2017
Merged

Map types #66

merged 3 commits into from Mar 20, 2017

Conversation

dahlia
Copy link
Member

@dahlia dahlia commented Mar 19, 2017

Although the runtime library already had had serializer and deserializer for maps, they weren't correctly implemented according to the spec. Map should be encoded as an array of objects e.g. [{"key": ..., "value": ...}] since keys can be more than primitive types, but it had encoded map as an object e.g. {...: ...}.

Also, as Python doesn't offset immutable dict, I implemented a simple immutable dict. Though its name is Map to follow Nirum's own terms.

@kanghyojun
Copy link
Member

이거 머지하면 0.3-maintanence 마스터에 머지하고 닫아야겠네요

@dahlia dahlia merged commit 4d43a1e into nirum-lang:master Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants