Update to v5 Boilerplate, Mixin Name Changes, Linting and Style Improvements #28
Conversation
tohuw
commented
Feb 24, 2015
tohuw
commented
- Removed any elements or calls deprecated in H5BP v5
- Added Browser Upgrade styles
- Test files updated for new upstream version
- An .editorconfig file has been added, to encourage style consistency among contributors
- config.rb added to assist with tests
- Updates and minor linting changes to Gemspec
- Several updates and improvements to the README
- The ignore file now excludes Sublime Text project and workspace files
- Added an inline title to the license
Name change to allow upload to ruby gems as a distinct gem, as the original seems to not be actively maintained anymore. Merging back upstream would be trivial enough.
Fixed warnings from gem build
Also cleaned up the config.rb to use the tests properly.
this version will not compete with its ancestor upstream.
Incremented version for clarity, as 0.2.0 had already been pushed.
A few minor clarifications and style tweaks to the README.
Another minor tweak to the README to fix a broken list.
Yet another tweak to README... list formats are such a pain sometimes...
Now one can include @html5bp for a full application of the styles, optionally redefining @html5bp-custom. Reordered imports for cleanliness. Added WIP 404 style. Corrected helper mixins to match naming conventions used elsewhere.
Clarified mixin names. Completed 404 styles and renamed the document. Suitably modified the README.
Conflicts: README.md
Also corrected missing line endings.
Added MIT title
Future versions will appropriately comply to semantic versioning. Bumping the major version more correctly denotes the overall lack of straight backwards-compatibility with Peter’s original work.
Importing changes made to README and LICENSE
sass-lint likes single quotes…
|
I suppose it's worth explicitly stating I actually changed all elements and mixins to match the v5 spec - I didn't just deprecate. :) Also, note the many mixin name changes. I think this is a more sane set of names, properly differentiating components of normalize.css and h5bp, and also better categorizing the h5bp elements involved. |
Update to v5 Boilerplate, Mixin Name Changes, Linting and Style Improvements
|
Very nice @tohuw! Sorry for the slow merge. Busy few weeks at work. |
|
Not a problem, of course. :) I have some future plans around possibly addressing #10, but I need to either fork and PR the latest normalize.css for them or wait for them to do it. In addition, I have to take another look at how they break it down and consider the compat effect that has on this code (specifically, whether it's worth a major version bump and backwards-incompatible mixin names just to have less code present in this library. Obviously, your opinion/insight around that is the final factor, but whether it's worth even pursuing is a Thing, as well. My current defense for a unique normalize is first to ensure a version lock with what H5BP is using, and second to allow flexible and opinionated assignments. I liken it to the fact that H5BP directly includes normalize.css; they don't include it as some submodule or so. Lastly, can you push the latest gem to rubygems.org, please. Once that's complete, I'll kill off compass-html5bp there. I doubt it had wide consumption, and whoever did stumble upon it would have no trouble finding your better-named and pre-existing gem. I've added myself as a watcher and am happy to attempt to assist with any issues that pop up in the tracker, as I'm able to do so - at least in terms of commenting, etc. Cheers. |
