Consume final ASM 6

[iloveeclipse]

Bad news: final ASM 6 will break API compared with ASM 6 BETA.
Good news: the change is small and they plan to release by the end of September.
So we should consider to switch to the final ASM 6 for the 3.1 release.

See https://mail.ow2.org/wws/arc/asm/2017-09/msg00000.html

[pdillinger]

The SpotBugs 3.1.0 description says "First SpotBugs release. Same features as FindBugs, plus proper support for Java 8."

Doesn't ASM 5.x have proper support for Java 8? Doesn't ASM 6 support Java 9? Do you mean Java 9? Is there a plan for Java 9 support?

[KengoTODA]

Doesn't ASM 5.x have proper support for Java 8?

ASM 5 supports Java 8. ASM 6 was introduced at FindBugs 3.1.0 preview version, to support Java 9.

Doesn't ASM 6 support Java 9?

ASM 6 beta support Java 9. You can refer official release note.

Do you mean Java 9? Is there a plan for Java 9 support?

We have plan to support Java 9, but it has no progress for now. Java 9 is not supported by ASM and other bytecode manupilation tools.

So Java 9 will not be supported by SpotBugs 3.1.0, I guess.

[iloveeclipse]

Java 9 is not supported by ASM and other bytecode manupilation tools.

??? ASM 6 has support for Java 9.

So Java 9 will not be supported by SpotBugs 3.1.0, I guess.

I guess we will support it (we had it in FindBugs already, see https://github.com/findbugsproject/findbugs/issues?q=java+9+label%3Ajava9), we just need to validate if the new Java 9 builds broke something again.

[KengoTODA]

??? ASM 6 has support for Java 9.

Then it's OK. Their release note says that does not work with javac 9 (yet !), so I wasn't so sure.

[KengoTODA]

we had it in FindBugs already

But Jigsaw broke FindBugs/SpotBugs so current master branch cannot support Java 9 for now 😭

[iloveeclipse]

But Jigsaw broke FindBugs/SpotBugs

Please create an issue for that, with details what is broken again and which JDK build was used.

[iloveeclipse]

Their release note says that does not work with javac 9 (yet !)

I believe this is about using ASM jars as modules for javac, but we don't care about that aspect.

[KengoTODA]

#101 is the related issue.

[iloveeclipse]

#101 is the related issue.

This is the issue only for running SpotBugs standalone. If SpotBugs is just used as a library (e.g. in Eclipse or maven/jenkins/whatever), it depends on the container configuration, and this is out of our control.

So if this is the only problem, then we can say that we support Java 9 if used as library. Standalone execution is easy to fix anyway, and we can also mention that too, if we didn't manage to merge #101 for 3.1.0 release.

BTW, I believe the #101 is already out-of-date, they changed their mind multiple times and I believe we need just to read some recent JDK 9 docs to get the right options set.

[KengoTODA]

OK, then our remaining TODO is just about ensuring that SpotBugs can work as library, right?

Then maybe we can make integration test which runs with Maven, And and Gradle. In my understanding we cannot automate test with Eclipse, then we need to check it by hands.

[iloveeclipse]

our remaining TODO is just about ensuring that SpotBugs can work as library, right?

Yes and no. We can and should try to fix the command line execution.

AFAIK the JDK guys seem to managed really final set of JVM arguments which are still needed for SpotBugs command line application to run. So we should check the latest JDK build/docs (where are they?!?!?, is this only we get: https://docs.oracle.com/javase/9/migrate/toc.htm#JSMIG-GUID-7BB28E4D-99B3-4078-BDC4-FC24180CE82B ?.

Eclipse seem to do some tricks with --add-modules=ALL-SYSTEM (I'm looking at Eclipse code with support for Java 9, see discussion and patches here: https://bugs.eclipse.org/bugs/show_bug.cgi?id=520636 and here: https://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=5ec02a751ee291e11f6bb6e76ab777f3eb930cc1).

However I don't see --add-modules=ALL-SYSTEM argument in the java documentation, only jdeps mentions this: https://docs.oracle.com/javase/9/tools/jlink.htm#JSWOR-GUID-CECAC52B-CFEE-46CB-8166-F17A8E9280E9 ?!?!?!?

I found https://docs.oracle.com/javase/9/tools/java.htm#JSWOR-GUID-4856361B-8BFD-4964-AE84-121F5F6CF111 where it says following:

--add-modules modulename[,modulename...]
Specifies the root modules to resolve in addition to the initial module. 
modulename can also be ALL-DEFAULT, ALL-SYSTEM, and ALL-MODULE-PATH.

But of course (!?!?!) there is not a single word what all the options actually do.

Beside this, JDK docu say that "--illegal-access=debug" can be used to trace down reflection related issues.

[KengoTODA]

where are they?!?!?

😭

[KengoTODA]

I've confirmed that:

• compile without additional javac parameter cannot pass on JRE9
• unit test cannot pass on JRE9
• smokeTest can pass on JRE9

Then I will propose a PR to use Java 9 to run smokeTest. -> #393

[iloveeclipse]

ASM 6.0 will be released tomorrow.