Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin file handles are leaking #589

Closed
roberthubert opened this issue Mar 17, 2018 · 2 comments
Closed

Plugin file handles are leaking #589

roberthubert opened this issue Mar 17, 2018 · 2 comments

Comments

@roberthubert
Copy link

When investigating the File handle to findsecbugs-plugin.jar is leaking issue reported in sonar-findbugs (spotbugs/sonar-findbugs#128)

I found out that the actual issues are in spotbugs.

Here is the commit that demonstrates the issue and a quick-and-dirty fix:
roberthubert@7c47138

I found two major issues in spotbugs:

  • URLClassLoaders are not closed
  • JarURLConnection are created with the useCaches flag set to true

I would like to kindly ask for a review.
(The code I provided isn't ready for the pull request.)
@KengoTODA KengoTODA mentioned this issue Mar 18, 2018
Closed
@h3xstream
Copy link
Member

h3xstream commented Mar 28, 2018 •
edited

Excellent work. 👍
Is there a PR for the fix ? Found #591

@gtoison
Copy link
Contributor

gtoison commented Aug 30, 2023

This was fixed by #2025

@gtoison gtoison closed this as completed Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@h3xstream @roberthubert @gtoison