Fix nil-returns from methods with nonnull return type #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
I personally support this change, but... shouldn't we update our Obj-c guidelines first to be consistent? |
|
@iOSCowboy: We can hold off merging until we’ve officially updated them 😺 Just bothered me that I couldn’t build the project without getting all these warnings 😝 |
|
@rastersize: Totally. It's like walking with a pebble in your shoe. |
|
Style in our guidelines has been updated, spotify/ios-style#5. Merging this change. |
rastersize
added a commit
that referenced
this pull request
Feb 25, 2016
…ethods-returning-nil Fix nil-returns from methods with nonnull return type
rastersize
deleted the
nullability/fix-nonnull-return-methods-returning-nil
branch
|
You never lifted the finger from the trigger for this one @rastersize |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caught by running the analyzer bundled with Xcode 7.3 beta 3. Most of the problems were due to the early-return segment of the init methods:
Also fixed a the type of some methods that should return
nilas well as updated the documentation for those.@spotify/objc-dev