Simplify slather + coveralls #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jgavris @rastersize: seems to have worked ;) |
|
Note that coverage dropped because I excluded the files in |
|
Thanks @dflems! I'll bump the coverage limit back to 78%. |
| @@ -4,10 +4,5 @@ set -euo pipefail | |||
|
|
|||
| bundle exec slather coverage \ | |||
| --input-format profdata \ | |||
| --cobertura-xml \ | |||
| --ignore "../**/*/Xcode*" \ | |||
| --output-directory slather-report \ | |||
There was a problem hiding this comment.
We can remove this from the .gitignore now as well?
There was a problem hiding this comment.
Yup. I'll delete that and test that the new limit is working.
|
Awesome, thanks @dflems! |
|
👍 Ignore the coverage decrease... |
ChocoChipset
pushed a commit
to ChocoChipset/SPTDataLoader
that referenced
this pull request
Jan 29, 2016
Remove the completed request objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were calling slather twice. The second time, ignore wasn't set properly, so system framework coverage data was being posted to coveralls. This PR should simplify things. If this works, we can close #11.