Don't use enumerateByteRangesUsingBlock

[gitrema]

This is basically a revert for
844112c

It is actually not clear how enumerateByteRangesUsingBlock can fix any
crash there but on the other hand is causing unnecessary callback and
delay in data delivering.

[codecov]

Codecov Report

Merging #220 (c7c64b6) into master (96adb9b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head c7c64b6 differs from pull request most recent head c6f47b9. Consider uploading reports for the commit c6f47b9 to get more accurate results

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
- Coverage   94.56%   94.55%   -0.02%     
==========================================
  Files          26       26              
  Lines        1325     1322       -3     
==========================================
- Hits         1253     1250       -3     
  Misses         72       72              

Flag	Coverage Δ
ios	94.22% <ø> (-0.05%)	⬇️
macos	94.47% <100.00%> (-0.02%)	⬇️
tvos	94.22% <ø> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...es/SPTDataLoader/SPTDataLoaderRequestTaskHandler.m	98.97% <100.00%> (-0.04%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96adb9b...c6f47b9. Read the comment docs.

[gitrema]

@kmcbride @dflems would you mind to take a look at it?

[kmcbride]

I'm not familiar with the scenario that the original commit addressed, but it looks like Apple recommends using that approach: https://developer.apple.com/documentation/foundation/nsurlsessiondatadelegate/1411528-urlsession#discussion

[gitrema]

thanks for the link I missed that recommendation. On the other hand if I get it correctly they are talking about when the bytes property on NSData is used and that is when you need to have access to the underlying memory directly. The method implementation does not have that requirement and either append the coming data in an NSMutableData object or pass them to the observer

[kmcbride]

OK, good point — it should be left up to the delegate to enumerate the bytes if needed.