Implement -debugDescription for Request and Response #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review: @rastersize, @8W9aG, @jgavris |
Cast enumeration to `long` for a -stringWithFormat: in `-debugDescription` of SPTDataLoaderRequest.
|
You'll need to add tests for this (in order to keep coverage up) |
| @@ -181,4 +181,10 @@ - (NSDate *)retryAfterForHeaders:(NSDictionary *)headers | |||
| return [httpDateFormatter dateFromString:retryAfterValue]; | |||
| } | |||
|
|
|||
| - (NSString *)debugDescription | |||
| { | |||
| return [NSString stringWithFormat:@"%@ { URL: %@ } { status code: %lu, headers: %@ }", [super debugDescription], self.response.URL, (long)self.statusCode, self.responseHeaders]; | |||
There was a problem hiding this comment.
You've specified that the status code should be long unsigned but you then cast it to only long.
|
With some tests and the type fix this will be golden 😃 |
Implement unit tests for debugDescription methods of SPTDataLoaderRequest and SPTDataLoaderResponse.
|
Good catch, @rastersize. Changed them to |
|
👍 |
rastersize
added a commit
that referenced
this pull request
Feb 2, 2016
Implement -debugDescription for Request and Response
|
hooray! 🎉 |
|
Can also use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
-debugDescriptionmethods forSPTDataLoaderRequestandSPTDataLoaderResponse.Format of the output is the same as
NSURLResponseandNSURLRequest.