Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Service.Instance Scoped executors has no thread pool size limit #95

Closed
zalenski opened this issue Apr 26, 2016 · 3 comments
Closed

Service.Instance Scoped executors has no thread pool size limit #95

zalenski opened this issue Apr 26, 2016 · 3 comments
Milestone

Comments

@zalenski
Copy link
Contributor

instance.getExecutorService() uses Executors.newCachedThreadPool which has no thread pool size limit

see http://stackoverflow.com/questions/1800317/impossible-to-make-a-cached-thread-pool-with-a-size-limit

@zalenski
Copy link
Contributor Author

Maybe it could just be removed, it's not used much.

@pettermahlen
Copy link
Member

I would actually be in favour of removing this for 2.0 - I don't see that providing shared executor services is a good fit for the core of Apollo. It's something that can easily be done at the application level. @rouzwawi ?

@mattnworb
Copy link
Member

+1 for removal

@pettermahlen pettermahlen added this to the 2.0.0 milestone May 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants