APP-driven catalog entity page with GitHub Actions integration & routes & tabs #2076

shmidt-i · 2020-08-21T21:22:55Z

Draft PR that solves most of the #1536 discovered problems 💪
Work towards #1982

TLDR

JSX-driven approach
APP defines top-level routing in JSX (for the standlalone-pages types-of-plugins)
Plugins define their own relative routing system using RouteRefs & ReactRouter v6 APIs
Plugin-catalog exports smart component CatalogPage which accepts EntityPage as a prop
EntityPage is defined inside the APP, using helpers from plugin-catalog (Tabs, useEntity, etc)
Plugins, that supposed to live inside the EntityPage are now there in the APP, making it possible to compose/configure all you want out of it ;)

TLDR (more details)

// packages/app/App.tsx

import { CatalogPlugin } from '@backstage/plugin-catalog';
import { EntityPage } from './components/catalog';

const AppRoutes = () => (
  <Routes>
    <Route
      path="/catalog/*"
      element={<CatalogPlugin EntityPage={EntityPage} />}
    />
    {/* <Route path="/explore" element={<ExplorePlugin />} /> */}
  </Routes>
);

// packages/app/components/catalog/index.tsx

import { useEntity } from '@backstage/plugin-catalog';
import { ComponentEntity } from './Component';

export const EntityPage = () => {
  const entity = useEntity();
  switch (entity.kind) {
    case 'Component':
      return <ComponentEntity />;
    default:
      return <UnkownEntityKind />;
  }
};

// packages/app/components/catalog/Component.tsx

import { useEntity, EntityMetadataCard, EntityPageTabs as Tabs } from '@backstage/plugin-catalog';
import {GITHUB_ACTIONS_ANNOTATION, GithubActionsPlugin} from '@backstage/plugin-github-actions';

export const ComponentEntity = () => {
  const entity = useEntity();

  switch (entity.spec!.type) {
    case 'service':
      return <Service />;
    case 'website':
      return <Website />;
    default:
      return <UnkownEntity />;
  }
};

const Service = () => {
	const entity = useEntity();

  const isCIAvailable = [
    entity!.metadata!.annotations?.[GITHUB_ACTIONS_ANNOTATION],
    entity!.metadata!.annotations?.[CIRCLE_CI_ANNOTATION],
  ].some(Boolean);

  return (
    <Tabs>
      <Tabs.Tab title="Overview" path="/" exact>
        <OverviewPage />
      </Tabs.Tab>
      {isCIAvailable && (
        <Tabs.Tab title="CI/CD" path="/ci-cd">
          {entity!.metadata!.annotations?.[GITHUB_ACTIONS_ANNOTATION] && (
            <GitHubActionsPlugin entity={entity} />
          )}
        </Tabs.Tab>
      )}
      <Tabs.Tab title="Docs" path="/docs">
        <div>Docs tab contents</div>
      </Tabs.Tab>
    </Tabs>
  );}

const OverviewPage = () => {
  const entity = useEntity();

  return (
    <Grid item sm={4}>
      <EntityMetadataCard entity={entity} />
    </Grid>
  );
};

shmidt-i · 2020-08-21T21:26:22Z

packages/app/src/App.tsx

+      path="/catalog/*"
+      element={<CatalogPlugin EntityPage={EntityPage} />}
+    />
+    {/* <Route path="/explore" element={<ExplorePlugin />} /> */}


Top-level registration of other plugins

shmidt-i · 2020-08-21T21:27:04Z

packages/app/src/components/Root/Root.tsx

@@ -89,7 +89,7 @@ const Root: FC<{}> = ({ children }) => (
      <SidebarSearchField onSearch={handleSearch} />
      <SidebarDivider />
      {/* Global nav, not org-specific */}
-      <SidebarItem icon={HomeIcon} to="./" text="Home" />
+      <SidebarItem icon={HomeIcon} to="/catalog" text="Home" />


With this routing strategy catalog needs to move to /catalog

which is probably fine, redirects can handle landing page changes

Also here it's nicely clear that we could change it to "Home" and have any icon etc, so it's not the plugin that decided.

However, that leads to the question - when introducing a new plugin into your Backstage installation, will you HAVE to invent both paths, labels (such as in the sidebar), AND icons to wire them in? Or can we have some form of helper that just sorts it out based on a root route ref that holds a default icon and label and route, which all can be overridden? Kinda like <SidebarItem ref={catalogRef} /> or something

Yup a routeRef (ref is reserved 😅) prop for the SidebarItem is missing, we definitely want that.

We should preferably be able to generate a sidebar given a static config similar to this:

sidebar: items: - ref: catalog.catalog - ref: scaffolder.create - divider - ref: explore.explore - ref: techdocs.docs

shmidt-i · 2020-08-21T21:29:33Z

plugins/catalog/src/components/EntityPageTabs/EntityPageTabs.tsx

+    });
+    routes.push({
+      path: '/*',
+      element: <Navigate to="." />,


Catch-all to go to the nearest /.
. works, .. works as well. / in this case would've been resolved to the very top level / as in localhost:3000/

shmidt-i · 2020-08-21T21:33:03Z

plugins/catalog/src/components/EntityPageTabs/EntityPageTabs.tsx

+    });
+  });
+  const [matchedRoute] =
+    matchRoutes(routes as RouteObject[], `/${params['*']}`) ?? [];


Since we are only inside /catalog/:kind/:optionalNameAndNamespace/* route at this particular point, this params['*'] gets resolved into anything that comes after optionalNameAndNamespace.
Example:
For the http://localhost:3000/catalog/Component/backstage/some/deep/route - params['*'] === "some/deep/route"

shmidt-i · 2020-08-21T21:33:56Z

plugins/catalog/src/components/EntityPageTabs/EntityPageTabs.tsx

+  const currentTab = tabs[selectedIndex];
+  const title = currentTab.label;
+
+  const onTabChange = (index: number) => navigate(tabs[index].id.slice(1, -2));


Removing leading / and trailing /* to enable built-in React Router v6 relative route resolution mechanism

shmidt-i · 2020-08-21T21:34:59Z

plugins/catalog/src/components/EntityPageTabs/EntityPageTabs.tsx

+  path: string;
+  exact?: boolean;
+};
+EntityPageTabs.Tab = (_props: TabProps) => null;


Basically a fake component, which allows us to collect its props

shmidt-i · 2020-08-21T21:35:31Z

plugins/catalog/src/hooks/useEntity.ts

+
+const REDIRECT_DELAY = 2000;
+
+export const EntityContext = createContext<Entity>((null as any) as Entity);


This guy powers useEntity hook

shmidt-i · 2020-08-21T21:37:26Z

plugins/catalog/src/routes.ts

  title: 'Entity',
 });
 export const entityRouteDefault = createRouteRef({
  icon: NoIcon,
-  path: '/catalog/:kind/:optionalNamespaceAndName',
+  path: ':kind/:optionalNamespaceAndName',


Here is no leading / - to enable <Link to={someRouteRef.path} /> being relative link.
For params - generatePath from react-router works

The primary use-case for route-refs is linking into a plugin from other plugins or the app, doesn't this break that?

Btw, once we've settled the way we wanna do composition we want to have another look at route refs. Maybe they're not needed at all, but if they are we should convert the path to a method that takes params. In this case the type of the route ref would be something like RouteRef<[kind: string, optionalNamespaceAndName: string]>

The original RFC briefly hinted at this, but what I think we're really looking for here are immutable relative route refs. Something that lets you specify a route ref in relation to another route ref, where overrides on the second one would be reflected in the first.

shmidt-i · 2020-08-21T21:38:41Z

plugins/github-actions/src/components/WorkflowRunDetails/WorkflowRunDetails.tsx

@@ -170,6 +162,10 @@ export const WorkflowRunDetails = () => {
  }
  return (
    <div className={classes.root}>
+      <Breadcrumbs aria-label="breadcrumb">
+        <Link to="..">Workflow runs</Link>


.. means one level up, not to closest parent sadly. But I think this is good enough ;)

shmidt-i · 2020-08-21T21:39:38Z

plugins/github-actions/src/plugin.ts

-    router.addRoute(projectRouteRef, WorkflowRunsPage);
-    router.addRoute(buildRouteRef, WorkflowRunDetailsPage);
-  },
+  register() {},


Maybe not needed anymore? 🤷‍♂️

Fox32 · 2020-08-22T08:01:43Z

packages/app/src/components/catalog/index.tsx

+  switch (entity.kind) {
+    case 'Component':
+      return <ComponentEntity />;
+    default:


Here we could fit in the APIEntityPage, looking forward to these changes!

freben

sorry i only got partway ... will have to continue tomorrow

freben · 2020-08-24T14:46:02Z

packages/app/src/components/Root/Root.tsx

@@ -89,7 +89,7 @@ const Root: FC<{}> = ({ children }) => (
      <SidebarSearchField onSearch={handleSearch} />
      <SidebarDivider />
      {/* Global nav, not org-specific */}
-      <SidebarItem icon={HomeIcon} to="./" text="Home" />
+      <SidebarItem icon={HomeIcon} to="/catalog" text="Home" />


which is probably fine, redirects can handle landing page changes

packages/app/src/App.tsx

freben · 2020-08-24T14:49:38Z

plugins/catalog/src/Router.tsx

+  );
+};
+
+export const CatalogPlugin = ({ EntityPage }) => (


We should probably not name a component *Plugin. The plugin should be the abstract notion of the entire plugin and all of the various things it exposes. CatalogPage or CatalogRoot or similar would make more sense.

Yuuuuuuup. In general I think we can come up with a couple of suffixes for people to use depending on what is being exported. For example *Page and *Card.

I'm also thinking that all of these exported components will be wrapped by the plugin, so that we can inject a plugin context, pick up APIs, and ensure that they're all dynamically loaded.

freben · 2020-08-24T14:50:46Z

packages/app/src/App.tsx

+  <Routes>
+    <Route
+      path="/catalog/*"
+      element={<CatalogPlugin EntityPage={EntityPage} />}


would be nice here if the EntityPage prop was optional and had a simple but usable default implementation.

freben · 2020-08-24T14:53:27Z

packages/app/src/components/Root/Root.tsx

@@ -89,7 +89,7 @@ const Root: FC<{}> = ({ children }) => (
      <SidebarSearchField onSearch={handleSearch} />
      <SidebarDivider />
      {/* Global nav, not org-specific */}
-      <SidebarItem icon={HomeIcon} to="./" text="Home" />
+      <SidebarItem icon={HomeIcon} to="/catalog" text="Home" />


Also here it's nicely clear that we could change it to "Home" and have any icon etc, so it's not the plugin that decided.

However, that leads to the question - when introducing a new plugin into your Backstage installation, will you HAVE to invent both paths, labels (such as in the sidebar), AND icons to wire them in? Or can we have some form of helper that just sorts it out based on a root route ref that holds a default icon and label and route, which all can be overridden? Kinda like <SidebarItem ref={catalogRef} /> or something

freben · 2020-08-24T14:57:43Z

packages/app/src/components/catalog/Component.tsx

+import { Grid } from '@material-ui/core';
+
+const OverviewPage = () => {
+  const entity = useEntity();


thinking that this API should probably be const { entity } = useEntity();, so we easily can tack more onto it - such as refresh() or whatever that is needed

freben · 2020-08-24T14:59:54Z

packages/app/src/components/catalog/Component.tsx

+  const entity = useEntity();
+
+  const isCIAvailable = [
+    entity!.metadata!.annotations?.[GITHUB_ACTIONS_ANNOTATION],


Should entity be nullable? Is that in like error conditions or something, is my first question then? Would be nice as a consumer to know it's always set, or an exception is thrown by the hook.

One more thing, is the exclamation mark necessary on metadata? I think we set it as required.

Probably both things are fixable

freben · 2020-08-24T15:00:35Z

packages/app/src/components/catalog/Component.tsx

+
+  return (
+    <Tabs>
+      <Tabs.Tab title="Overview" path="/" exact>


the exact thing can be deprecated under react-router 6 right?

This is not the react-router exact though, it's part of the Tabs implementation

Sure but maybe we want to change the tab implementation.

freben · 2020-08-24T15:00:57Z

packages/app/src/components/catalog/Component.tsx

+        <Tabs.Tab title="CI/CD" path="/ci-cd">
+          {entity!.metadata!.annotations?.[GITHUB_ACTIONS_ANNOTATION] && (
+            <GitHubActionsPlugin entity={entity} />
+          )}


forgot circleci here :) yeah i know it's illustrative

I think that the GitHubActionsPlugin component should not be named Plugin, as a plugin is the whole package, this component is the GithubActionsPage rather, IIUC.

Or is this the actual way to hook in a full plugin?

freben · 2020-08-24T15:09:06Z

packages/app/src/components/catalog/Component.tsx

+
+export const ComponentEntity = () => {
+  const entity = useEntity();
+  switch (entity.spec!.type) {


Question is if this switch is necessary - should we have to switch out / duplicate logic for choice of tabs, sidebar, etc per type? Maybe. Just wondering if it's the right "granularity".

emmaindal · 2020-08-24T15:32:03Z

packages/app/src/components/catalog/Component.tsx

+          )}
+        </Tabs.Tab>
+      )}
+      <Tabs.Tab title="Docs" path="/docs">


I guess we want to have something similar to isCIAvailable here but isDocsAvailable or something and check the techdocs ref annotation to only show the Docs tab on entities that actually have docs?

Yes, point being - since it's JSX, one can introduce whatever logic is necessary

ooor was that only for illustration purposes? xD

Rugvip · 2020-08-25T08:16:13Z

plugins/catalog/src/routes.ts

  title: 'Entity',
 });
 export const entityRouteDefault = createRouteRef({
  icon: NoIcon,
-  path: '/catalog/:kind/:optionalNamespaceAndName',
+  path: ':kind/:optionalNamespaceAndName',


The primary use-case for route-refs is linking into a plugin from other plugins or the app, doesn't this break that?

Btw, once we've settled the way we wanna do composition we want to have another look at route refs. Maybe they're not needed at all, but if they are we should convert the path to a method that takes params. In this case the type of the route ref would be something like RouteRef<[kind: string, optionalNamespaceAndName: string]>

Rugvip · 2020-08-25T08:27:43Z

packages/app/src/components/Root/Root.tsx

@@ -89,7 +89,7 @@ const Root: FC<{}> = ({ children }) => (
      <SidebarSearchField onSearch={handleSearch} />
      <SidebarDivider />
      {/* Global nav, not org-specific */}
-      <SidebarItem icon={HomeIcon} to="./" text="Home" />
+      <SidebarItem icon={HomeIcon} to="/catalog" text="Home" />


Yup a routeRef (ref is reserved 😅) prop for the SidebarItem is missing, we definitely want that.

We should preferably be able to generate a sidebar given a static config similar to this:

sidebar: items: - ref: catalog.catalog - ref: scaffolder.create - divider - ref: explore.explore - ref: techdocs.docs

Rugvip · 2020-08-25T08:31:04Z

packages/app/src/components/catalog/Component.tsx

+      </Tabs.Tab>
+      {isCIAvailable && (
+        <Tabs.Tab title="CI/CD" path="/ci-cd">
+          {entity!.metadata!.annotations?.[GITHUB_ACTIONS_ANNOTATION] && (


It will be tricky to generate an app based on static config if this kind of logic lives in the app. No need to fix as a part of this PR, but something we should look at after.

Rugvip · 2020-08-25T08:36:59Z

plugins/catalog/src/Router.tsx

+  );
+};
+
+export const CatalogPlugin = ({ EntityPage }) => (


Yuuuuuuup. In general I think we can come up with a couple of suffixes for people to use depending on what is being exported. For example *Page and *Card.

I'm also thinking that all of these exported components will be wrapped by the plugin, so that we can inject a plugin context, pick up APIs, and ensure that they're all dynamically loaded.

…pp-catalog-tabs-routes-everything-is-connected

shmidt-i · 2020-08-31T21:40:36Z

plugins/catalog/src/hooks/useEntity.ts

+};
+
+/**
+ * Always going to return an entity, or throw an error if not a descendant of a EntityProvider.


@freben - that's what you wanted, right?

Yep. But I'm not sure about the type in there, looks complex :)

…pp-catalog-tabs-routes-everything-is-connected

stefanalund · 2020-09-01T09:48:52Z

docs/plugins/index.md

@@ -26,3 +26,10 @@ This helps the community know what plugins are in development.

 You can also use this process if you have an idea for a good plugin but you hope
 that someone else will pick up the work.
+
+## Integrate into the catalog service


Service Catalog?

shmidt-i · 2020-09-01T11:21:49Z

packages/app/src/components/catalog/EntityPage.tsx

+);
+
+const DefaultEntityPage = ({ entity }: { entity: Entity }) => (
+  <EntityPageLayout>


Try to move on top of EntityPage

shmidt-i · 2020-09-01T11:32:21Z

plugins/catalog/src/components/EntityPageLayout/Tabbed/Tabbed.tsx

+    const navigate = useNavigate();
+
+    React.Children.forEach(children, child => {
+      if (!React.isValidElement(child)) {


Check if child type is actually Content

shmidt-i · 2020-09-01T11:36:13Z

plugins/catalog/src/components/EntityPageLayout/Tabbed/Tabbed.tsx

+          onChange={onTabChange}
+        />
+        <Content>
+          <Grid container spacing={3}>


Remove Grid

shmidt-i · 2020-09-01T11:41:17Z

plugins/catalog/src/hooks/useEntity.ts

+  }, [errorApi, navigate, error, loading, entity]);
+
+  if (!name) {
+    navigate('/catalog');


shmidt-i · 2020-09-01T11:43:56Z

plugins/catalog/src/hooks/useEntity.ts

+
+type EntityLoadingStatus = {
+  entity?: Entity;
+  loading: boolean | null;


shmidt-i · 2020-09-01T11:44:04Z

plugins/catalog/src/hooks/useEntity.ts

+
+export const EntityContext = createContext<EntityLoadingStatus>({
+  entity: undefined as any,
+  loading: null,


true in the beginning

shmidt-i · 2020-09-01T11:55:46Z

plugins/catalog/src/routes.ts

  title: 'Entity',
 });
 export const entityRouteDefault = createRouteRef({
  icon: NoIcon,
-  path: '/catalog/:kind/:optionalNamespaceAndName',
+  path: ':kind/:optionalNamespaceAndName/*',


Remove /*

shmidt-i · 2020-09-01T12:02:39Z

Leave old AppRoutes as well

…pp-catalog-tabs-routes-everything-is-connected

Addresses the changes required after merging backstage#2076. The Sentry plugin now defines a router and the widget will be displayed as a tab.

feat: IoC, DI, indirection, routes, tabs, catalog, app, github-actions

d3db3a7

shmidt-i requested a review from a team August 21, 2020 21:23

shmidt-i linked an issue Aug 21, 2020 that may be closed by this pull request

API for connecting plugin pages as tabs on entity pages #1982

Closed

shmidt-i commented Aug 21, 2020

View reviewed changes

shmidt-i requested review from emmaindal and hooloovooo August 21, 2020 21:41

Fox32 reviewed Aug 22, 2020

View reviewed changes

fix: move catch-all route out of loop

e76d33e

freben reviewed Aug 24, 2020

View reviewed changes

emmaindal reviewed Aug 24, 2020

View reviewed changes

Rugvip reviewed Aug 25, 2020

View reviewed changes

shmidt-i added 5 commits August 31, 2020 16:02

feat(catalog, app): new api 4 plugins integration

43ac2c0

test(catalog): test Tabbed implementation

e57798c

docs: plugin integration into catalog

713060d

Merge branch 'master' of github.com:spotify/backstage into shmidt-i/a…

6847475

…pp-catalog-tabs-routes-everything-is-connected

fix: adjust code after rebasing

e8259d1

shmidt-i commented Aug 31, 2020

View reviewed changes

refactor: simplify optional chaining

8539b14

shmidt-i marked this pull request as ready for review August 31, 2020 21:46

shmidt-i linked an issue Aug 31, 2020 that may be closed by this pull request

GitHub Actions: provide a context with an entity to the plugin #1859

Closed

shmidt-i added 7 commits September 1, 2020 00:13

fix(github-actions): cards

5127da1

Merge branch 'master' of github.com:spotify/backstage into shmidt-i/a…

9b0ddfe

…pp-catalog-tabs-routes-everything-is-connected

chore(eslint): adjust no-unused-vars rule

a62d0af

fix: update create-app to match example-app

542ee25

fix: typedep

7dc5425

Merge branch 'master' of github.com:spotify/backstage into shmidt-i/a…

2a39b60

…pp-catalog-tabs-routes-everything-is-connected

fix: AboutCard

7b09888

stefanalund reviewed Sep 1, 2020

View reviewed changes

fix: typedeps again

39f7394

stefanalund mentioned this pull request Sep 1, 2020

[Plugin] Datadog Integration #849

Closed

shmidt-i commented Sep 1, 2020

View reviewed changes

shmidt-i added 2 commits September 1, 2020 14:19

fix: e2e tsc

aa2eeb8

fix: e2e hanging

9a99a92

iain-b mentioned this pull request Sep 2, 2020

Is there any plan of adding a Widget to this? RoadieHQ/backstage-plugin-github-pull-requests#7

Closed

shmidt-i added 7 commits September 2, 2020 15:57

refactor: address PR comments

9988479

Merge branch 'master' of github.com:spotify/backstage into shmidt-i/a…

7834bca

…pp-catalog-tabs-routes-everything-is-connected

fix: test

ad76c61

Merge branch 'master' of github.com:spotify/backstage into shmidt-i/a…

217c709

…pp-catalog-tabs-routes-everything-is-connected

fix(create-app): add deprecatedAppRoutes

73aa8b9

Merge branch 'master' of github.com:spotify/backstage into shmidt-i/a…

3a6150b

…pp-catalog-tabs-routes-everything-is-connected

refactor: OverviewPage -> OverviewContent

6f353c2

muffix mentioned this pull request Sep 3, 2020

Conditionally add Sentry widget to component page #2258

Merged

6 tasks

stefanalund approved these changes Sep 3, 2020

View reviewed changes

Rugvip approved these changes Sep 3, 2020

View reviewed changes

shmidt-i merged commit 64ecf77 into master Sep 3, 2020

shmidt-i deleted the shmidt-i/app-catalog-tabs-routes-everything-is-connected branch September 3, 2020 12:06

shmidt-i mentioned this pull request Sep 3, 2020

GithubActions Logging Implementation #2172

Merged

6 tasks

muffix pushed a commit to muffix/backstage that referenced this pull request Sep 4, 2020

Adapt app-driven entity page

eb4d54f

Addresses the changes required after merging backstage#2076. The Sentry plugin now defines a router and the widget will be displayed as a tab.

Rugvip mentioned this pull request Sep 6, 2020

app: invert plugin composition to build pages in app #1998

Closed

shmidt-i mentioned this pull request Sep 8, 2020

Solve sub routing for ComponentPage #1042

Closed

marcuseide mentioned this pull request Oct 13, 2020

Not able to run plugins individually (techdocs, lighthouse, etc.) #2707

Closed

awanlin mentioned this pull request Sep 15, 2023

💬 RFC: New Catalog UI Plugin #19911

Closed

2 tasks


		const REDIRECT_DELAY = 2000;

		export const EntityContext = createContext<Entity>((null as any) as Entity);

APP-driven catalog entity page with GitHub Actions integration & routes & tabs #2076

APP-driven catalog entity page with GitHub Actions integration & routes & tabs #2076

Conversation

shmidt-i commented Aug 21, 2020 • edited Loading

TLDR

TLDR (more details)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

freben left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shmidt-i commented Sep 1, 2020

shmidt-i commented Aug 21, 2020 •

edited

Loading