create-app: include missing plugins as part of the template #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, sorry that we've been slow to adopt this - you seem to have to rebase now. |
ayshiff
force-pushed
the
feature/create-app-plugins-circleci-explore
branch
from
ec2c6be
to
af89201
Compare
ayshiff
force-pushed
the
feature/create-app-plugins-circleci-explore
branch
from
af89201
to
1637987
Compare
marcuseide
reviewed
Sep 1, 2020
|
|
||
| import { | ||
| techdocsStorageApiRef, | ||
| TechDocsStorageApi, | ||
|
|
||
| techdocsStorageApiRef, |
There was a problem hiding this comment.
Seems like a duplicate import snuck in here...
marcuseide
approved these changes
Sep 2, 2020
|
@ayshiff Thanks! 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Fixes #1843
This adds the missing plugins to the app.
✔️ Checklist
yarn test