core: refactor SessionStateApi to SessionApi with sign-in/out #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freben
approved these changes
Sep 22, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
logoutfrom theOAuthApiandOpenIdApito theSessionStateApiand renames it toSessionApi.It also renames all mentions of
logoutin the frontend tosignOut, since that's the terminology we've settled on.While at it I also added a
signInto theSessionApi, which keeps things symmetrical, but also enables the implementation of the settings items to be much more generic.I experimented with a
LogoutApias well, but putting it all in aSessionApifelt like a reasonable separation of concerns while not making things too granular.1st commit contains the changes, 2nd one is just generated doc updates.