backend: add service discovery interface and implement for single host deployments #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rugvip
changed the title
freben
reviewed
Sep 25, 2020
| listenPort = DEFAULT_PORT, | ||
| } = readBaseOptions(config.getConfig('backend')); | ||
| const protocol = config.has('backend.https') ? 'https' : 'http'; | ||
| const internalBaseUrl = `${protocol}://${listenHost}:${listenPort}`; |
There was a problem hiding this comment.
Can listenHost be :: or 0.0.0.0 for example? Is it always possible to form the url using these components?
There was a problem hiding this comment.
That should work just fine, changed it to support IPv6 though
There was a problem hiding this comment.
Probably nicer to translate those to localhost even if it happens to work though, updated that too
|
|
||
| const catalogRes = await fetch(`${catalogUrl}/entities/by-name/${triple}`); | ||
| if (!catalogRes.ok) { | ||
| catalogRes.body.pipe(res.status(catalogRes.status)); |
There was a problem hiding this comment.
Fancy. And this works whether there's a body or not?
There was a problem hiding this comment.
Should, an empty pipe is still a pipe, no? 😁
Rugvip
force-pushed
the
rugvip/disco
branch
3 times, most recently
from
c9bb58c
to
880d8b9
Compare
Rugvip
force-pushed
the
rugvip/disco
branch
from
880d8b9
to
4e84e3f
Compare
Rugvip
force-pushed
the
rugvip/disco
branch
from
4e84e3f
to
2a443ce
Compare
Rugvip
force-pushed
the
rugvip/disco
branch
from
943ce8c
to
5893efb
Compare
Rugvip
force-pushed
the
rugvip/disco
branch
from
5893efb
to
1ae59f0
Compare
benjdlambert
approved these changes
Sep 25, 2020
|
@benjdlambert couldn't find any docs to update, cept for the changelog |
|
Ok maybe one for an upcoming docs party. |
freben
approved these changes
Sep 25, 2020
|
@spotify/techdocs-core can I get your approval too? |
hooloovooo
approved these changes
Sep 25, 2020
This was referenced Sep 25, 2020
80 tasks
taras
added a commit
to taras/backstage
that referenced
this pull request
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1847, #2596
Went with an interface similar to the frontend
DiscoveryApi, since it's dead simple but still provides a lot of flexibility in the implementation.Also ended up with two different methods, one for internal endpoint discovery and one for external. The two use-cases are explained a bit more in the docs, but basically it's service-to-service vs callback URLs.
This did get me thinking about uniqueness and that we're heading towards a global namespace for backend plugin IDs. That's probably fine tbh, but if we're happy with that we should leverage it a bit more to simplify the backend setup. For example we'd have each plugin provide its own ID and not manually mount on paths in the backend.
Draft until we're happy with the implementation, then I can add more docs and changelog entry. Also didn't go on a thorough hunt for places where discovery can be used, but tbh I don't think there are many since it's been pretty awkward to do service-to-service communication.