We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Since #39 was merged, there is an inconsistent minimum note length:
predict
predict_and_save
model_output_to_notes
I can make a PR to make it consistently 127.7 ms (11 frames), but that would be backwards incompatible. Is this acceptable?
The text was updated successfully, but these errors were encountered:
Also, funnily enough, the minimum note length in basicpitch.io says it's in milliseconds, but it seems to be in frames.
Sorry, something went wrong.
Hey @matangover, nice catch! I've made a PR to resolve all minimum_note_length to 127.70 ms. Once it is merged I will resolve this issue.
Thank you!
dohertyguirand
No branches or pull requests
Since #39 was merged, there is an inconsistent minimum note length:
predict
it's 127.7 ms (11 frames)predict_and_save
the default is 58 msmodel_output_to_notes
the default is 5 framesI can make a PR to make it consistently 127.7 ms (11 frames), but that would be backwards incompatible. Is this acceptable?
The text was updated successfully, but these errors were encountered: