Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent minimum note length #93

Closed
matangover opened this issue Aug 29, 2023 · 3 comments
Closed

Inconsistent minimum note length #93

matangover opened this issue Aug 29, 2023 · 3 comments
Assignees

Comments

@matangover
Copy link

Since #39 was merged, there is an inconsistent minimum note length:

  • When calling predict it's 127.7 ms (11 frames)
  • When using the command line it's 58 ms (5 frames)
  • In predict_and_save the default is 58 ms
  • In model_output_to_notes the default is 5 frames

I can make a PR to make it consistently 127.7 ms (11 frames), but that would be backwards incompatible. Is this acceptable?

@matangover
Copy link
Author

Also, funnily enough, the minimum note length in basicpitch.io says it's in milliseconds, but it seems to be in frames.

@dohertyguirand
Copy link
Member

Hey @matangover, nice catch! I've made a PR to resolve all minimum_note_length to 127.70 ms. Once it is merged I will resolve this issue.

@matangover
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants