Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Pandas requirement to 1.0.0 #106

Closed

Conversation

tomasaschan
Copy link
Contributor

What this PR does / why we need it:

Pandas 1.0 has been out for a few months, and seems stable enough that we should start supporting it!

In addition, I noticed some inconsistencies between versions used in the package requirements itself,
and in the requirements specified for local development. These have now been rectified (and future-proofed)
by including the package requirements.txt from the dev one instead of specifying everything twice.

Special notes for your reviewer:

On my local setup (Windows with WSL) there are some problems with chromedriver that I haven't been
able to figure out. Because of this, saving images as png doesn't work, and thus that test has been
skipped when I've tested locally. I doubt that it would make a difference for this change, but might
be worth double-checking in the PR builds.

Release note:

Bump Pandas requirement to 1.0

@tomasaschan
Copy link
Contributor Author

py3.5 fails because it can't find pandas>=1.0.0<2, which makes sense - Pandas 1.0 requires Python 3.6.1 or higher. What is the policy for supporting 3.5 here? Would it make sense to bump Chartify's minimum python version to 3.6 too (and make the corresponding tox config updates)?

py3.6 fails with the following TypeError:

pd.MultiIndex(
                levels=[['a', 'b'], ['1', '2', '3']],
                labels=[[0, 0, 0, 1, 1], [1, 0, 2, 0, 1]],
>               names=['category1', 'category2'])
E           TypeError: __new__() got an unexpected keyword argument 'labels'

Assume this is something that has changed in the Pandas API and I can change the code accordingly. However, that won't help if Chartify must keep supporting 3.5.

Is it OK to drop 3.5 support?

@cphalpert
Copy link
Contributor

Sure, I'm open to bumping the python version minimum to be in line with the newest pandas requirements. Thanks for your help with this!

@tomasaschan
Copy link
Contributor Author

Cool! I'll update this PR with those changes tomorrow.

Which Python versions should I add to the tox test specs? All the way up to 3.9?

@cphalpert
Copy link
Contributor

cphalpert commented Apr 22, 2020 via email

@tomasaschan
Copy link
Contributor Author

The build error on 3.8 seems to be related to some recently introduced thing in Pyflakes, and we're getting a pretty old version for some reason. Investigating...

@cphalpert
Copy link
Contributor

Thanks Tomas! Building off of your work here #108

@cphalpert cphalpert closed this May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants