New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Pandas requirement to 1.0.0 #106
Bump Pandas requirement to 1.0.0 #106
Conversation
py3.5 fails because it can't find py3.6 fails with the following
Assume this is something that has changed in the Pandas API and I can change the code accordingly. However, that won't help if Chartify must keep supporting 3.5. Is it OK to drop 3.5 support? |
Sure, I'm open to bumping the python version minimum to be in line with the newest pandas requirements. Thanks for your help with this! |
Cool! I'll update this PR with those changes tomorrow. Which Python versions should I add to the tox test specs? All the way up to 3.9? |
Yeah that works
…On Tue, Apr 21, 2020, 3:18 PM Tomas Aschan ***@***.***> wrote:
Cool! I'll update this PR with those changes tomorrow.
Which Python versions should I add to the tox test specs? All the way up
to 3.9?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#106 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIJL6C3ISFSCFDJVNRORALRNXWPXANCNFSM4MKPS42A>
.
|
6d25e77
to
6a8dabe
Compare
Mainly to get a version that includes tox-dev/tox#914
6a8dabe
to
d34a854
Compare
The build error on 3.8 seems to be related to some recently introduced thing in Pyflakes, and we're getting a pretty old version for some reason. Investigating... |
Thanks Tomas! Building off of your work here #108 |
What this PR does / why we need it:
Pandas 1.0 has been out for a few months, and seems stable enough that we should start supporting it!
In addition, I noticed some inconsistencies between versions used in the package requirements itself,
and in the requirements specified for local development. These have now been rectified (and future-proofed)
by including the package
requirements.txt
from the dev one instead of specifying everything twice.Special notes for your reviewer:
On my local setup (Windows with WSL) there are some problems with chromedriver that I haven't been
able to figure out. Because of this, saving images as png doesn't work, and thus that test has been
skipped when I've tested locally. I doubt that it would make a difference for this change, but might
be worth double-checking in the PR builds.
Release note: