Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Storage check #61

Merged
merged 3 commits into from
Nov 15, 2023
Merged

feat: Storage check #61

merged 3 commits into from
Nov 15, 2023

Conversation

Calibretto
Copy link
Contributor

  • Adds a function to check if the storage has something in it.
  • Fixes some compiler warnings on unused variables.
  • Adds thread safety to Storage mock.

@Calibretto Calibretto changed the title Storage check feat: Storage check Nov 7, 2023
vahidlazio
vahidlazio reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@vahidlazio vahidlazio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we also use this in the demo app to define different strategies?

@Calibretto
Copy link
Contributor Author

Ready for review.

@Calibretto Calibretto merged commit db74dd5 into main Nov 15, 2023
3 checks passed
@Calibretto Calibretto deleted the storage-check branch November 15, 2023 09:24
@github-actions github-actions bot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vahidlazio vahidlazio vahidlazio approved these changes

@fabriziodemaria fabriziodemaria Awaiting requested review from fabriziodemaria fabriziodemaria is a code owner

@mfranberg mfranberg Awaiting requested review from mfranberg mfranberg is a code owner

@nicklasl nicklasl Awaiting requested review from nicklasl nicklasl is a code owner

@nickybondarenko nickybondarenko Awaiting requested review from nickybondarenko nickybondarenko is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Calibretto @vahidlazio