Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Documentation for public protocols/constructors #111

Merged
merged 2 commits into from
May 2, 2024
Merged

docs: Documentation for public protocols/constructors #111

merged 2 commits into from
May 2, 2024

Conversation

fabriziodemaria
Copy link
Member

Also:

@fabriziodemaria fabriziodemaria mentioned this pull request May 2, 2024
Closed
nicklasl
nicklasl approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@nicklasl nicklasl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally I'd like the doc thing to be separate from the fix to provide a good changelog. Now I think the bug fix will not be included in the changelog.

@fabriziodemaria
Copy link
Member Author

Ideally I'd like the doc thing to be separate from the fix to provide a good changelog. Now I think the bug fix will not be included in the changelog.

Agreed, I was a bit lazy with avoiding rebases. We haven't released the bug anyway, so it's maybe even nicer to not have the fix in the changelog

@fabriziodemaria fabriziodemaria merged commit 01dda08 into main May 2, 2024
3 checks passed
@fabriziodemaria fabriziodemaria deleted the docs branch May 2, 2024 12:18
@github-actions github-actions bot mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicklasl nicklasl nicklasl approved these changes

@mfranberg mfranberg Awaiting requested review from mfranberg mfranberg is a code owner

@vahidlazio vahidlazio Awaiting requested review from vahidlazio vahidlazio is a code owner

@nickybondarenko nickybondarenko Awaiting requested review from nickybondarenko nickybondarenko is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabriziodemaria @nicklasl