fix: Revert "fix: Reconciliation bug" #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
requested review from
mfranberg,
vahidlazio,
nicklasl and
nickybondarenko
as code owners
This reverts commit 6bdbf95.
fabriziodemaria
force-pushed
the
revert-fix
branch
from
4662dd9
to
d6b7193
Compare
fabriziodemaria
commented
May 3, 2024
| @@ -87,7 +87,6 @@ public class Confidence: ConfidenceEventSender { | |||
| var map = confidence.contextFlow.value | |||
| for removedKey in removeKeys { | |||
| map.removeValue(forKey: removedKey) | |||
| confidence.removedContextKeys.insert(removedKey) | |||
There was a problem hiding this comment.
This function is only called from the Provider and we don't want the diffed OF keys to be removed from this Confidence descendants
vahidlazio
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6bdbf95.