Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Manage Events - track app lifecycle events #118

Merged
merged 30 commits into from
May 10, 2024
Merged

Conversation

vahidlazio
Copy link
Contributor

No description provided.

@vahidlazio vahidlazio changed the base branch from main to move-flag-evaluation-confidence May 6, 2024 12:25
@vahidlazio vahidlazio marked this pull request as ready for review May 6, 2024 12:35
@vahidlazio vahidlazio changed the title feat: [WIP] Manage Events - track app lifecycle events feat: Manage Events - track app lifecycle events May 6, 2024
@vahidlazio vahidlazio changed the base branch from move-flag-evaluation-confidence to main May 6, 2024 16:42
Copy link
Member

@fabriziodemaria fabriziodemaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need at least some basic unit tests before merging

Comment on lines 106 to 107
case UIApplication.didFinishLaunchingNotification:
track(eventName: "app-launched")
Copy link
Member

@fabriziodemaria fabriziodemaria May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am having issues getting this event emitted properly (with the is_foreground context), due to the order of function calls and notifications

@fabriziodemaria
Copy link
Member

Notes from manual testing:

  • app-installed is sent twice
  • app-updated is sent three times (as well as app-launched), when the version changes
  • app-launched doesn't include is_foreground context (I believe Android has it)

@fabriziodemaria fabriziodemaria force-pushed the analytics-swift branch 4 times, most recently from 67dc9f8 to 4ba7df7 Compare May 8, 2024 13:06
Copy link
Member

@fabriziodemaria fabriziodemaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing from Demo app seem to work correctly now. Approved!

@fabriziodemaria fabriziodemaria merged commit e74af7c into main May 10, 2024
3 checks passed
@fabriziodemaria fabriziodemaria deleted the analytics-swift branch May 10, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants