Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing livenessProbe and readinessProbe Configuration in Task Manager and Job Manager Pod Spec #105

Closed
hjwalt opened this issue Sep 16, 2021 · 5 comments

Comments

@hjwalt
Copy link
Contributor

hjwalt commented Sep 16, 2021

Right now the following is the default provided:

  livenessProbe:
    failureThreshold: 5
    initialDelaySeconds: 5
    periodSeconds: 60
    successThreshold: 1
    tcpSocket:
      port: 6123
    timeoutSeconds: 10

Occasionally we encounter an unusual situation where the task manager did not reach RPC port start up, and was terminated by k8s. But when the port starts up while the pod is in terminating state, the job gets submitted, and killed eventually, creating a restart loop (which after some time resolves when magically the task manager starts before 25 seconds).

I can work on this and create pull request here if you think this is useful.

@regadas
Copy link
Contributor

regadas commented Sep 16, 2021

Hi @hjwalt yeah I think that exposing these can be useful indeed; If you can create a PR please do.

@hjwalt hjwalt changed the title Exposing livenessProbe Configuration in Task Manager Pod Spec Exposing livenessProbe and readinessProbe Configuration in Task Manager Pod Spec Sep 20, 2021
@numbnut
Copy link

numbnut commented Sep 21, 2021

Hi @hjwalt and @regadas ,
I was as well facing this and raised it in issue 94. I will remove it there, because now it is duplicated. I have two more points.

  1. In the GCP Operator it was actually working to set livenessProbe and readynessProbe. I'm not sure, why it has been removed. I thought it might be helpful to mention this.
  2. Would you mind to implement it for the jobmanager as well?

@hjwalt hjwalt changed the title Exposing livenessProbe and readinessProbe Configuration in Task Manager Pod Spec Exposing livenessProbe and readinessProbe Configuration in Task Manager and Job Manager Pod Spec Sep 22, 2021
@hjwalt
Copy link
Contributor Author

hjwalt commented Sep 22, 2021

@numbnut sure, I'll add the same for job manager

@numbnut
Copy link

numbnut commented Sep 22, 2021

Hi @hjwalt , thank you!

@regadas
Copy link
Contributor

regadas commented Sep 24, 2021

Closed via #111

@regadas regadas closed this as completed Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants