Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spotify for iOS version 8.4.91 released 2/2/19 broke SPTLoginSampleSwift #93

Closed
appsird opened this issue Feb 2, 2019 · 33 comments
Closed
Labels
bug Something isn't working

Comments

@appsird
Copy link

appsird commented Feb 2, 2019

The new release of Spotify was auto-loaded onto my phone overnight. Took me a couple hours to determine this broke the example. Can you please provide a working update.

@sean118
Copy link

sean118 commented Feb 4, 2019

Having the same issue: Tap on "CONNECT" opens the Spotify app and from there nothing more happens. Using the "SPTLoginSampleAppSwift" example in Spotify iOS SDK v1.0.1.

@Lukapp
Copy link

Lukapp commented Feb 4, 2019

No example works. My app is based on the examples and it does not work either, try to initiate the session, open the spotify app but do not initialize the session

@appsird
Copy link
Author

appsird commented Feb 4, 2019

try to initiate the session, open the spotify app but do not initialize the session

same here. No callbacks from SPTSessionManagerDelegate following call to:

sessionManager.initiateSession(with: scope, options: .clientOnly)

Could not determine how to back down to the prior rev iOS Spotify, though that is only a temporary fix. It appears the API changed. There is an article on the Community board:

https://developer.spotify.com/community/news/2019/01/15/update-changes-to-playlist-uris/

The playlist URI change has now been scheduled for February 28th, 2019.

Possibly these changes were rolled in early which affected? It seems we require a revised SpotifyiOS.framework file incorporating new changes.

@appsird
Copy link
Author

appsird commented Feb 5, 2019

Posting to bump issue to top. This recent release of Spotify iOS apparently renders all third party developer applications inoperative. Would appreciate a fix, please advise.

@marcinwlodarczyk
Copy link

marcinwlodarczyk commented Feb 5, 2019

I'm experiencing the same issue.
Is the Spotify app trying to perform a request when not being in Active state yet and not as a background task (when handling the auth url from the 3rd party app)?
This is the log that made me thinking about the above as the root cause:
nw_protocol_boringssl_error(1584) <private>[0x16454d8f0] Lower protocol stack error: 53

@virajd49
Copy link

virajd49 commented Feb 6, 2019

Facing the same issue. Nothing happens beyond the "connect Spotify" button. My own app based on the quick start guide also ends up the same - nothing beyond the sessionManager.initiateSession(with: scope, options: .clientOnly) call.

@Lukapp
Copy link

Lukapp commented Feb 6, 2019

I tried to authorize the app via the web API and get the token, to share it with SPTAppRemote, but it does not work either, open the spotify app and return it as an invalid token. Getting the token with ios-sdk was valid for use with the web api. I thought I could do it like that but I do not know if it's because there's no session created, but you can not do it.

captura de pantalla 2019-02-06 a las 9 05 16

@arirawr
Copy link

arirawr commented Feb 6, 2019

Hey folks - thanks for the reports. We're looking into this, and I'll post here when we have updates.

@arirawr arirawr added the bug Something isn't working label Feb 6, 2019
@sean118
Copy link

sean118 commented Feb 6, 2019

I believe this could potentially be related to the parsing of the url in the application(_:open:options:) method in the AppDelegate of the Spotify App.

Possibly related to new URIs, there may be a new or modified parsing method that consumes the incoming spotify-action://authorize url and silently treats it as an unrecognised URI, before it could actually be handled properly by the correct authentication method.

Just an idea and maybe a starting point

@appsird
Copy link
Author

appsird commented Feb 6, 2019

Sean118 seems on a viable trajectory..

Thanks Arielle for investigating.

Please request Spotify iOS development team implement Xcode continuous integration to assure no recurrence at a later time.

https://developer.apple.com/library/archive/documentation/IDEs/Conceptual/xcode_guide-continuous_integration/index.html#//apple_ref/doc/uid/TP40013292-CH1-SW1

@cjam
Copy link

cjam commented Feb 7, 2019

I'm experiencing a similar issue, after updating to Spotify 8.4.91. I'm also using an older version of the SDK (1.0.0) in my project and I'm curious as to how the SDK devs are versioning the SDK. I have assumed that it is semver but.. if it's not then that could be a culprit as well.

It would be nice to have more visibility into changes in the Spotify App that might impact the use of this SDK. It will be hard to have an app that can broken by users updating their Spotify. Perhaps someone from Spotify has a thought on this.

@mato2593
Copy link

mato2593 commented Feb 7, 2019

I'm experiencing the same issue but only on iOS 12, on iOS 11 it's working fine

@appsird
Copy link
Author

appsird commented Feb 7, 2019 via email

@virajd49
Copy link

virajd49 commented Feb 7, 2019

I stumbled across this by mistake: In the Quick Start example, if you leave the LSApplicationQueriesSchemes field empty - when the session.initate call is made - you get a "" wants to use "spotify.com" to Sign In - Cancel / Continue alert box - this opens a sort of web page where you sign in - and returns back to the app - Successful authentication. I tried it multiple times to make sure it works. I also tried to see if the same would work for the LoginSampleApp and it does, but you need to additionally change the initiateSession options to '.default' - it takes me to the login page, but the login fails for this one.

Not sure if this is a viable workaround or not, but might as well try it while we wait for an update.

@cjam
Copy link

cjam commented Feb 7, 2019

Interesting @mato2593, are you using the auth flow that goes through the Spotify App? (vs webView)

@appsird
Copy link
Author

appsird commented Feb 7, 2019

I will attempt the three mato2593 test scenarios today using auth flow, and report back by tomorrow.

@mato2593
Copy link

mato2593 commented Feb 7, 2019

I tested in production, so I downloaded the apps from the Appstore. I tested building the app for iOS 11 and running on iOS 11 and it worked too. I still have to test running on iOS 12 after building for 11 or 12.

Interesting @mato2593, are you using the auth flow that goes through the Spotify App? (vs webView)

We're not using the SDK (at this moment I don't remember why we had to do this, we implemented this more than a year ago), but we're using the flow that goes through the Spotify App if installed. If the Spotify app isn't installed we open the Spotify web to get the auth code.

@sean118
Copy link

sean118 commented Feb 8, 2019

@mato2593: Are both your iOS versions, of which iOS 11 seems to work fine, running on two different iOS devices? I've now come across a case where the authentication is still working fine on the current iOS 12 version, but running on an older iPhone 7 device - so possibly there is (also) a device based switch involved in the issue.

But we definitely need someone with access to the code of the core Spotify app to investigate.

@arirawr What is the current state of the investigation?

In case its difficult to find a starting point: I think a good place to start the investigation could be to look at the application(_:open:options:) method in the AppDelegate and follow the path of parsing an incoming url in the format: spotify-action://authorize. I think it could be accidentally consumed too early by a resource lookup function or similar.

Please keep us updated. I understand it's a complex cross-departmental issue at Spotify, but it's also breaking a core feature of an official SDK that has already moved out of beta, so I hope it is getting some attention.

Thanks

@appsird
Copy link
Author

appsird commented Feb 8, 2019

I hope it is getting some attention.

Yes, seems like we may be grasping at straws.

  • compiled for iOS 11.0, ran on iOS 12.1.4, iPhone 8, still fails
  • compiled for iOS 11.0, ran on iOS 12.1.4, iPhone 7, still fails

I lack liberty to revert to iOS 11 on a device.

@arirawr: please provide an update on your triage process and possible ETA for a fix

@mato2593
Copy link

mato2593 commented Feb 8, 2019

@mato2593: Are both your iOS versions, of which iOS 11 seems to work fine, running on two different iOS devices? I've now come across a case where the authentication is still working fine on the current iOS 12 version, but running on an older iPhone 7 device - so possibly there is (also) a device based switch involved in the issue.

Yes, iPhone X running iOS 12.1.2 and iPhone 6 running iOS 11.2.5.

@Lukapp
Copy link

Lukapp commented Feb 8, 2019

Fixed 8.4.92

@appsird
Copy link
Author

appsird commented Feb 8, 2019

Fixed 8.4.92

Available now in iOS App Store. I downloaded and appears authorization is now working again.

Thanks.

@appsird
Copy link
Author

appsird commented Feb 9, 2019

Folks,

My two-thumbs-up may have been premature. Using Spotify iOS release 8.4.92 seems a step in the proper direction, though I remain unable to run SPTLoginSampleSwift. It appears I receive a callback in AppDelegate:

func application(_ app: UIApplication, open url: URL, options: [UIApplicationOpenURLOptionsKey : Any] = [:]) -> Bool {

Though, later receive callback sessionManager:manager:didFailWIth

I'm running the latest iOS 12.1.2 on iPhone 8, with Spotify iOS release 8.4.92.

Would appreciate other input, is this new release working for you?

@mato2593
Copy link

mato2593 commented Feb 9, 2019

It appears to be working fine with the latest release of Spotify on my iPhone X. I'm checking with the client if the issue is fixed for him too. Will provide more information later

@virajd49
Copy link

virajd49 commented Feb 9, 2019

Spotify update 8.4.92 working for me as well. Running iOS 12.1.4 on iPhone 6.

@appsird
Copy link
Author

appsird commented Feb 9, 2019

Thanks. 8.4.92 seems to be working properly now.

@sean118
Copy link

sean118 commented Feb 9, 2019

Thanks all, everything's up and running for me too 👍 (iPhone XS, latest iOS 12)

@ikhsan
Copy link

ikhsan commented Feb 11, 2019

We're seeing similar problem in production for Songkick's iOS app.

The last 2 version of Spotify app (v8.4.91 and v8.4.92) broke our Spotify authentication. We saw ~25% dip on our conversion. We received several user reports about it as well.

It'll be great to hear some update on this issue. 🙇‍♂️

@cjam
Copy link

cjam commented Feb 11, 2019

Can confirm that the auth flow in my app has been fixed by 8.4.92, thanks guys.

@appsird
Copy link
Author

appsird commented Feb 11, 2019

Again, 8.4.92 is working now for myself.

Would appreciate official notice from Spotify Developer support this is the complete fix - and nothing remains regarding the issue. Then, close this issue.

@arirawr
Copy link

arirawr commented Feb 18, 2019

This issue should now be resolved in Spotify app version 8.4.92. Thanks for all your reports!

Please feel free to reopen if you continue to see this issue occur.

@arirawr arirawr closed this as completed Feb 18, 2019
@ikhsan
Copy link

ikhsan commented Feb 21, 2019

Confirming that v8.4.92 solves our issue. That version had a slower roll out than v8.4.91 so I was assuming prematurely, sorry about that.

@ben-daghir
Copy link

I have found the same issue with iOS 12.2 and Spotify 8.5.0.833. Authorization flow works up until the session is initialized. There is no trigger for the didInitiateSession after authorization. No errors either. Essentially returns to the app without making the post request to my server to swap the key.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants