Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use updated documentation style. #7

Merged
merged 2 commits into from Jan 23, 2017

Conversation

cerihughes
Copy link
Contributor

Use this form:

/**
 Sets an action for a given type
 @param action The block containing the action to perform
 @param type The type denoting when to perform that actions
 */

instead of this:

/**
 * Sets an action for a given type
 * @param action The block containing the action to perform
 * @param type The type denoting when to perform that actions
 */

*/

stop(); // Hammer-time!

// this is a very brief comment.
```

* Use [doxygen](http://www.stack.nl/~dimitri/doxygen/manual/docblocks.html)-style comments for all the headers. Make
sure to use the available markup tags like `@param`, `@return`, etc. The `///` form is preferred for single line
* Document all methods and properties in the headers using Xcode8's documentation style. You can select a property
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xcode8's 👉 Xcode 8’s

I.e. space between Xcode and 8 and typographic apostrophe.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha. You and your apostrophes! :) Will fix!

sure to use the available markup tags like `@param`, `@return`, etc. The `///` form is preferred for single line
* Document all methods and properties in the headers using Xcode8's documentation style. You can select a property
or method and use `Cmd`-`/` to see this in action. Make sure to use the available markup tags like `@param`,
`@return`, etc. (these will be auto-generated for you by Xcode8). The `///` form is preferred for single line
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about omitting the Xcode version number here. Since it was made clear in the sentences just before. Also gets old in just a few months :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed.

*
* This is a new paragraph in the same block comment.
This is a multi-line comment. The opening and closing markers are on their
own lines, and each other line is preceded by a * that is indented by one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove “, and each other line is preceded by a * that is indented by one space.” Since its no longer true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops. Well spotted.

Copy link

@marmelroy marmelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@rastersize rastersize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎻

@rastersize rastersize merged commit 5f0416a into spotify:master Jan 23, 2017
@cerihughes cerihughes deleted the update-documentation-style branch January 23, 2017 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants