-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get ready for Python2 deprecation #2830
Comments
How should we handle versioning for this support deprecation? While day 0 will just be the removal of Python 2 testing, 2.7 will continue to work for a short time. Do we go ahead and major increase at that time? |
I think I makes sense to do a major release on day 0 even there is nothing as major. It is a promise that we no longer support py2 and will start introducing py3 only features. I also think we should remove six and all the other try import catch thingy. Wdyt? |
That sounds great |
@drowoseque Of course not. |
I finally came with following idea about For each method in this module we
after that we remove |
I think I'm done with erasing py2-support in luigi |
Nice to see it finally happening! |
Removing six and related docs then I think we are good. Thanks a lot for your great contribution @drowoseque . Good job! Next step I'm thinking to release a few beta versions on that branch before merging to master (we should hold on till 2020 at least). What do you think, folks? We should also try to find a few beta testers, including Spotify as one of them. |
We might as well stop supporting old versions of py3. I mean removing https://github.com/spotify/luigi/blob/master/setup.py#L115-L118 |
we in cian.ru will gladly test this beta-version |
@honnix |
@drowoseque I rebased from master. I don't have permission to make the change you requested either. I'm actually not sure whether it is doable to give write permission to a branch. |
Label makes it easier to track all the PRs: https://github.com/spotify/luigi/pulls?utf8=%E2%9C%93&q=label%3A%22Python2+deprecation%22+ |
@drowoseque 3.0.0b1 is now available on pypi: https://pypi.org/project/luigi/3.0.0b1/ |
@honnix release notes lgtm. I am not a luigi user at my job anymore so i can't easily validate the beta release against representative pipelines. |
@dlstadther No worries. Let's try to get more people onboard, somehow. :) |
@drowoseque Have you been able to test |
@honnix we have new versions |
|
I think we can give it two more weeks, then merge to master and release. |
Now it has been more than 2 weeks. I think we can move on merging the PR and release 3.0.0. wdyt @drowoseque @dlstadther @Tarrasch ? |
@honnix sounds good! |
SGTM |
@honnix |
Sorry this has been taking longer. I unfortunately cannot just do it now. We are having a discussion internally and hopefully we can sort it out very soon. |
@honnix Python3 for the win. :) |
@Tarrasch @dlstadther PTAL at the release notes https://github.com/spotify/luigi/releases/tag/untagged-fe738e7cd4ef344c93fc and the PR to kick off the release #2953 |
3.0.0 has been shipped. |
@dlstadther @Tarrasch It's almost there. We will need to give people heads-up before dropping Python2 CI.
The text was updated successfully, but these errors were encountered: