Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PROTO3 Option[T] support #123

Closed
nevillelyh opened this issue May 12, 2020 · 1 comment
Closed

PROTO3 Option[T] support #123

nevillelyh opened this issue May 12, 2020 · 1 comment

Comments

@nevillelyh
Copy link
Contributor

After some internal discussion this is what we'll do:

  • remove check that fails PROTO3 with Option[T] fields
  • add warning to potential asymmetric conversion
  • for scala -> proto, Some(0/""/false) and None are equivalent
  • for proto -> scala, we always get Some(0/""/false) but never None
@nevillelyh
Copy link
Contributor Author

Fixed in #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nevillelyh