Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magnolify.bigtable.ByteStringComparator is built with Java 11 since 0.4.7 release #609

Closed
mattnworb opened this issue Sep 27, 2022 · 0 comments

Comments

@mattnworb
Copy link
Member

mattnworb commented Sep 27, 2022

It looks like the class magnolify.bigtable.ByteStringComparator is accidentally being compiled with Java 11 since version 0.4.7:

$ javap -v -cp magnolify-bigtable_2.12-0.4.8.jar magnolify.bigtable.ByteStringComparator  | grep "major version"
  major version: 55

$ javap -v -cp magnolify-bigtable_2.12-0.4.7.jar magnolify.bigtable.ByteStringComparator  | grep "major version"
  major version: 55

$ javap -v -cp magnolify-bigtable_2.12-0.4.6.jar magnolify.bigtable.ByteStringComparator  | grep "major version"
  major version: 52

list of classfile major versions by release

I noticed this does not happen for all classes in the jar, perhaps a difference between the Java sources and Scala sources in https://github.com/spotify/magnolify/tree/main/bigtable/src:

$ javap -v -cp magnolify-bigtable_2.12-0.4.8.jar magnolify.bigtable.BigtableType  | grep "major version"
  major version: 52

$ javap -v -cp magnolify-bigtable_2.12-0.4.8.jar magnolify.bigtable.Columns  | grep "major version"
  major version: 52

This came up when a team recently upgraded to version 0.4.8 (from 0.4.6) of the library (I'll fill this in later) on a pipeline running on Cloud Dataflow with Java 8 workers:

java.lang.UnsupportedClassVersionError: magnolify/bigtable/ByteStringComparator has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants