Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'application/json' hard-coded as response body type #12

Closed
jenner opened this issue May 26, 2015 · 1 comment
Closed

'application/json' hard-coded as response body type #12

jenner opened this issue May 26, 2015 · 1 comment

Comments

@jenner
Copy link

jenner commented May 26, 2015

The [resp_body](https://github.com/spotify/ramlfications/blob/master/ramlfications/parser.py#L927-L948 function) returns only bodies of type 'application/json', however the RAML spec state that you may have more then one media type in a response specifications (e.g. epending on your request's Accept header)
jenner added a commit to jenner/ramlfications that referenced this issue May 26, 2015
@jenner
fixed parsing responses bodies, see jdiegodcp#12
e467515 
- The responses bodies map is now accepting more then just
  'application/json' media types. If there's no valid media
  type, the default one is used and the body spec is
  inspected for 'schema' and 'example' parameters
- Added XSDs for thingy and thingy-list
- Added parser tests wrt response bodies parsing
jenner added a commit to jenner/ramlfications that referenced this issue May 26, 2015
@jenner
fixed parsing responses bodies, see jdiegodcp#12
f79a469 
- The responses bodies map is now accepting more then just
  'application/json' media types. If there's no valid media
  type, the default one is used and the body spec is
  inspected for 'schema' and 'example' parameters
- Added XSDs for thingy and thingy-list
- Added parser tests wrt response bodies parsing
@jenner
Copy link
Author

jenner commented Jun 1, 2015

Fixed in 740647e

@jenner jenner closed this as completed Jun 1, 2015
econchick pushed a commit to econchick/ramlfications that referenced this issue Jun 5, 2015
@jenner @econchick
fixed parsing responses bodies, see jdiegodcp#12
877e15f 
- The responses bodies map is now accepting more then just
  'application/json' media types. If there's no valid media
  type, the default one is used and the body spec is
  inspected for 'schema' and 'example' parameters
- Added XSDs for thingy and thingy-list
- Added parser tests wrt response bodies parsing
econchick pushed a commit to econchick/ramlfications that referenced this issue Jun 5, 2015
@jenner @econchick
fixed parsing responses bodies, see jdiegodcp#12
b90e890 
- The responses bodies map is now accepting more then just
  'application/json' media types. If there's no valid media
  type, the default one is used and the body spec is
  inspected for 'schema' and 'example' parameters
- Added XSDs for thingy and thingy-list
- Added parser tests wrt response bodies parsing
econchick pushed a commit to econchick/ramlfications that referenced this issue Jun 5, 2015
@jenner @econchick
fixed parsing responses bodies, see jdiegodcp#12
291c4ae 
- The responses bodies map is now accepting more then just
  'application/json' media types. If there's no valid media
  type, the default one is used and the body spec is
  inspected for 'schema' and 'example' parameters
- Added XSDs for thingy and thingy-list
- Added parser tests wrt response bodies parsing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jenner