Reworked URI params trait spec/tests. #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
econchick
added a commit
that referenced
this pull request
Dec 24, 2015
Reworked URI params trait spec/tests.
|
Great, no problem, and thanks a lot for looking at (all) this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at #37, I ran into this situation that I think shouldn't be allowed. According to RAML spec, http://raml.org/spec.html#uri-parameters, URI parameters should be present in the URI but their description via uriParameters property is optional (what leads me to #56).
If that makes sense, I think the complete-valid-example spec should be changed to be really valid? :-) Updating spec and tests here.