Add support to reverse DexGuard's resource file name obfuscation #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrHadiSatrio
force-pushed
the
dexguard_resource_mapping
branch
from
b8846bf
to
3eb8038
Compare
|
To illustrate what I meant by broken attribution, please observe the following table.
|
|
Amazing, thanks a lot for the contribution! I pushed a few commits to better align the changes with the rest of the project, but this should be good to merge if CI is happy. If you want you can also give it another try to make sure my "fixes" didn't break anything 😅 |
simonschiller
force-pushed
the
dexguard_resource_mapping
branch
from
0051014
to
3f25a25
Compare
simonschiller
approved these changes
Aug 18, 2022
|
My pleasure! Verified that everything still works as expected. 🙌 |
|
Awesome, then let's wait until @ViktorPetrovski or @botronic had time to review the two open PRs and then we can merge them and release a new version that should hopefully be fully compatible with DexGuard and ProGuard. |
|
LGTM 👍 Thanks to both of you! |
ViktorPetrovski
approved these changes
Aug 18, 2022
simonschiller
force-pushed
the
dexguard_resource_mapping
branch
from
3f25a25
to
5cb379b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed
Why was it changed
Related issues