Skip to content

Commit

Permalink
Remove credentials
Browse files Browse the repository at this point in the history
  • Loading branch information
JMPerez committed May 9, 2016
1 parent c76a864 commit 9c34fb5
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 12 deletions.
6 changes: 3 additions & 3 deletions authorization_code/app.js
Expand Up @@ -12,9 +12,9 @@ var request = require('request'); // "Request" library
var querystring = require('querystring');
var cookieParser = require('cookie-parser');

var client_id = '03ffe0cac0a0401aa6673c3cf6d02ced'; // Your client id

This comment has been minimized.

Copy link
@davidclevenger

This comment has been minimized.

Copy link
@HerrMenschenrechte

HerrMenschenrechte via email Feb 27, 2022

var client_secret = 'a57c43efb9644574a96d6623fb8bfbc2'; // Your client secret
var redirect_uri = 'http://localhost:8888/callback'; // Your redirect uri
var client_id = 'CLIENT_ID'; // Your client id
var client_secret = 'CLIENT_SECRET'; // Your secret
var redirect_uri = 'REDIRECT_URI'; // Your redirect uri

/**
* Generates a random string containing numbers and letters
Expand Down
5 changes: 2 additions & 3 deletions client_credentials/app.js
Expand Up @@ -9,9 +9,8 @@

var request = require('request'); // "Request" library

var client_id = '03ffe0cac0a0401aa6673c3cf6d02ced'; // Your client id
var client_secret = 'a57c43efb9644574a96d6623fb8bfbc2'; // Your client secret
var redirect_uri = 'http://localhost:8888/callback'; // Your redirect uri
var client_id = 'CLIENT_ID'; // Your client id
var client_secret = 'CLIENT_SECRET'; // Your secret

// your application requests authorization
var authOptions = {
Expand Down
4 changes: 2 additions & 2 deletions implicit_grant/public/index.html
Expand Up @@ -131,8 +131,8 @@ <h2>oAuth info</h2>

document.getElementById('login-button').addEventListener('click', function() {

var client_id = '03ffe0cac0a0401aa6673c3cf6d02ced'; // Your client id
var redirect_uri = 'http://localhost:8888/'; // Your redirect uri
var client_id = 'CLIENT_ID'; // Your client id
var redirect_uri = 'REDIRECT_URI'; // Your redirect uri

var state = generateRandomString(16);

Expand Down
7 changes: 3 additions & 4 deletions package.json
@@ -1,9 +1,8 @@
{
"author": "Doozer",
"name": "web-api-code-example",
"description": "Basic examples of the Spotify authorization flows through oAuth2",
"author": "Spotify",
"name": "web-api-auth-examples",
"description": "Basic examples of the Spotify authorization flows through OAuth 2",
"version": "0.0.1",
"main": "app.js",
"dependencies": {
"cookie-parser": "1.3.2",
"express": "~4.0.0",
Expand Down

1 comment on commit 9c34fb5

@HerrMenschenrechte
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JMPerez, just wanted to give you a heads up that your credentials are still exposed in this repository, albeit not in the version that people will most likely clone. Since you committed the credentials initially they will remain in the commit history unless you recreate the repository or purge them from prior commits using GIT.

BR

Please sign in to comment.