Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pseudonymization broken in examples #122

Open
arildm opened this issue Jan 14, 2019 · 4 comments
Open

Pseudonymization broken in examples #122

arildm opened this issue Jan 14, 2019 · 4 comments

Comments

@arildm
Copy link
Member

arildm commented Jan 14, 2019

In the examples (show options > show examples; only available when not connected to the backend), the first button will insert the unsolved example, and the second will insert the solved example (with corrections and added labels). The second button does not work with pseudonymization, because there is a mechanism that stores which label combination resulted in what pseudonym, and it happens to store the original tokens as pseudonyms.

@elenavolodina
Copy link
Member

we can skip fixing pseudonymization of examples.

@elenavolodina
Copy link
Member

There is another question: When the target text is pseudonymized in the spaghetti area, what should happen to the text area with the target text? Shouldn't the corresponding tokens be replaced with the pseudonyms as well? See a picture how it looks in the online Svala, anonymization mode (D-stad in the spaghetti is still Svanneke in the target text):

skarmavbild 2019-01-14 kl 18 43 44

@elenavolodina
Copy link
Member

elenavolodina commented Jan 15, 2019

After some going back and forth between modes (normalization, correction annotation, anonymiation), pseudomymization disappeared even from spaghetti (see "target text" line):

skarmavbild 2019-01-15 kl 13 45 47

@arildm
Copy link
Member Author

arildm commented Jan 15, 2019

There is another question: When the target text is pseudonymized in the spaghetti area, what should happen to the text area with the target text? Shouldn't the corresponding tokens be replaced with the pseudonyms as well?

This is now fixed on dev. I haven't had the chance to test it very thoroughly yet, but I wanted to push it there as quickly as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants