Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower pros & cons #31

Closed
demonslord opened this issue Aug 8, 2014 · 5 comments
Closed

Bower pros & cons #31

demonslord opened this issue Aug 8, 2014 · 5 comments

Comments

@demonslord
Copy link

Hi,
On my opinion, using the bower is good for repository size, but is not good for plugin, because you need always be "on alert" because the 3rd party plugins can be changed, and you need refactor your code.

At this moment, you need refactor this line:

jS.undo.manager.register(u, jS.undo.removeCells, [before, id], 'Remove Cells', u, jS.undo.createCells, [after, null, id], 'Create Cells');

Because the Javascript-Undo-Manager plugin was changed recently by author.

Best Regards.

@demonslord demonslord changed the title Bower [YES] or [NO] Bower Pros & cons Aug 8, 2014
@demonslord demonslord changed the title Bower Pros & cons Bower pros & cons Aug 8, 2014
@demonslord
Copy link
Author

Well,I checked the plugin Javascript-Undo-Manager, and the author has dropped support of arguments.

:(

@robertleeplummerjr
Copy link
Member

Well, that is no good.

@robertleeplummerjr
Copy link
Member

Suggestions?
On Aug 8, 2014 10:10 AM, "Alexander Bulei" notifications@github.com wrote:

Well,I checked the plugin Javascript-Undo-Manager, and the author has
dropped support of arguments.

:(


Reply to this email directly or view it on GitHub
#31 (comment)
.

@demonslord
Copy link
Author

Hi @robertleeplummerjr ,
Well, I see only one solution, use the old method, do commit of 3rd plugins to repository.

Best Regards.

@robertleeplummerjr
Copy link
Member

I ended up contact the developer and getting this bug worked out by upstreaming the existing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants