You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a critical issue that renders master and stable branches unusable. I already wrote about it in comments to PR #444, but since it is closed I'd like to bring the problem closer to your attention.
How to reproduce:
Install sample Spree application and configure it with SpreeI18n.
Translate a product name.
Visit products list page on frontend (list by taxon, or homepage if the product appears there), switch language and make sure the product name is being translated.
Open the product page. The name is not translated. Desired result: the name should be translated.
Same thing with taxons. They are translated in lists (i.e. in the sidebar), but not when you open taxon page or a product page with the taxon in "bread crumbs".
To quickly fix this issue, you should roll back changes made by PR #444. This may decrease back the performance, but at least the gem will be usable again. I'm not arguing that before #444 there were too many redundant requests to DB, but that patch needs more work before being merged to stable branches.
I'll try to figure this out and fix it keeping the performance gain, but if someone of the maintainers of this great gem will happen to see this issue before I succeed (or if I fail completely), it would be great if it was fixed by a rollback to pre-#444 state.
I added a PR #471 with a test against this regression earlier.
The text was updated successfully, but these errors were encountered:
This is a critical issue that renders master and stable branches unusable. I already wrote about it in comments to PR #444, but since it is closed I'd like to bring the problem closer to your attention.
How to reproduce:
Same thing with taxons. They are translated in lists (i.e. in the sidebar), but not when you open taxon page or a product page with the taxon in "bread crumbs".
To quickly fix this issue, you should roll back changes made by PR #444. This may decrease back the performance, but at least the gem will be usable again. I'm not arguing that before #444 there were too many redundant requests to DB, but that patch needs more work before being merged to stable branches.
I'll try to figure this out and fix it keeping the performance gain, but if someone of the maintainers of this great gem will happen to see this issue before I succeed (or if I fail completely), it would be great if it was fixed by a rollback to pre-#444 state.
I added a PR #471 with a test against this regression earlier.
The text was updated successfully, but these errors were encountered: