Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing keyword: :current_currency in -> ArgumentError in module ProductsFinderDecorator #195

Closed
old-software-engineer opened this issue Aug 26, 2021 · 5 comments

Comments

@old-software-engineer
Copy link

old-software-engineer commented Aug 26, 2021

missing keyword: :current_currency in this method ->ArgumentError in module ProductsFinderDecorator

When i implement the spree_multi_vendor gem then on product show page there will be throw error -> missing keyword: :current_currency

@old-software-engineer old-software-engineer changed the title missing keyword: :current_currency in -> ArgumentError in Spree::TaxonsController#show missing keyword: :current_currency in -> ArgumentError in module ProductsFinderDecorator Aug 26, 2021
@damianlegawiec
Copy link
Contributor

this is fixed in the main branch, we need to release it on rubygems

@myousry22
Copy link

@damianlegawiec @sharmaparas4444
Screen Shot 2021-09-18 at 2 04 36 AM

i have the same issue

@jakub-polak
Copy link

@damianlegawiec hi! When could we expect a bug fix to be released?

@djdarkbeat
Copy link

@jakub-polak You can add Spree::Config.currency as the argument being sent by currency:. We did this initially, in our local gem in ~/.rbenv/..etc to fix the problem. I was going to fork v2.2.0 and issue a PR with this change but ultimately we changed our Gemfile

from

gem "spree_multi_vendor"

to

gem "spree_multi_vendor", github: "spree-contrib/spree_multi_vendor", branch: "main"

And this solved the issue. We had recently updated to Spree 4.3 and got out gem pinned back on v2.2.0 as that's the last release and was from May.

@damianlegawiec
Copy link
Contributor

Hi @sharmaparas4444 @MuhammedYousryKamel @jakub-polak @djdarkbeat

v2.3.0 with Spree 4.3 fixes was pushed to RubyGems

bundle update spree_multi_vendor

should resolve this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants