Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

product packages have priority over dimensions #161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrpollo
Copy link
Contributor

@mrpollo mrpollo commented Nov 28, 2013

this is required so we don't send and extra package previously it would create a package with the default variant attributes and append it to the product packages, this would create in some cases expansive rate results

in some cases: carriers typically would measure the package and pick either the dimensions or the weight (whichever is more expensive) and use that to calculate the rates

this is required so we don't send and extra package
previously it would create a package with the default variant
attributes and append it to the product packages
@mrpollo
Copy link
Contributor Author

mrpollo commented Nov 28, 2013

don't merge this yet I need to redo some of the tests...

I'm also feeling that the whole weight array poop that is going on should be gone from here since we have the splitters on spree_core doing that job already ( splitting packages per weight )... would love input here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant