Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More brod options? #67

Closed
madshargreave opened this issue May 1, 2018 · 3 comments
Closed

More brod options? #67

madshargreave opened this issue May 1, 2018 · 3 comments

Comments

@madshargreave
Copy link
Contributor

Hi

Is is planned to add an option to supply the remaining brod consumer options like min_bytes and max_wait_time
@davidsantoso
Copy link
Contributor

@madshargreave yes we've talked about implementing those, but haven't done so yet or haven't made concrete plans to do so. Might because the couple of us that work on Kaffe have been in and out the last few weeks. Feel free to implement it and send a PR.

@madshargreave
Copy link
Contributor Author

madshargreave commented May 2, 2018 •
edited
Loading

@davidsantoso Added a PR

@objectuser
Copy link
Contributor

@madshargreave I merged this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davidsantoso @madshargreave @objectuser