Skip to content
This repository has been archived by the owner on Mar 6, 2020. It is now read-only.

ConnectionPoolMetricsTests occasionally fail with NaN. #31

Closed
mp911de opened this issue Aug 15, 2019 · 3 comments
Closed

ConnectionPoolMetricsTests occasionally fail with NaN. #31

mp911de opened this issue Aug 15, 2019 · 3 comments
Labels
for: external-project For an external project and not something we can fix type: regression A regression from a previous release
Milestone
0.1.0.M2

Comments

@mp911de
Copy link
Collaborator

mp911de commented Aug 15, 2019 

org.junit.ComparisonFailure: 
Expected :7.0
Actual   :NaN
<Click to see difference>


	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at org.springframework.boot.actuate.r2dbc.metrics.ConnectionPoolMetricsTests.assertGauge(ConnectionPoolMetricsTests.java:91)
	at org.springframework.boot.actuate.r2dbc.metrics.ConnectionPoolMetricsTests.doTest(ConnectionPoolMetricsTests.java:85)
	at org.springframework.boot.actuate.r2dbc.metrics.ConnectionPoolMetricsTests.metrics(ConnectionPoolMetricsTests.java:61)

or

org.junit.ComparisonFailure: expected:<[3.0]> but was:<[NaN]>
	at org.springframework.boot.actuate.r2dbc.metrics.ConnectionPoolMetricsTests.assertGauge(ConnectionPoolMetricsTests.java:83)
	at org.springframework.boot.actuate.r2dbc.metrics.ConnectionPoolMetricsTests.metrics(ConnectionPoolMetricsTests.java:74)
@mp911de mp911de added the type: regression A regression from a previous release label Aug 15, 2019
@mp911de
Copy link
Collaborator Author

mp911de commented Aug 15, 2019

See also #17.

@mp911de mp911de mentioned this issue Aug 15, 2019
Closed
@mp911de mp911de added this to the 0.1.0.M2 milestone Aug 15, 2019
@mp911de
Copy link
Collaborator Author

mp911de commented Aug 15, 2019

The fix is to upgrade to the latest build of 0.8.0 snapshots.

@mp911de mp911de added for: external-project For an external project and not something we can fix status: blocked An issue that is blocked on an external project change labels Aug 15, 2019
@mp911de mp911de removed the status: blocked An issue that is blocked on an external project change label Sep 10, 2019
@mp911de
Copy link
Collaborator Author

mp911de commented Sep 10, 2019 •
edited
Loading

Fixed via #34 by upgrading to a newer R2DBC Pool version.

@mp911de mp911de closed this as completed Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
for: external-project For an external project and not something we can fix type: regression A regression from a previous release
Milestone
0.1.0.M2
Development

No branches or pull requests
1 participant
@mp911de