Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

PubSubBinderConfiguration is not disabled when PubSub is disabled #2653

Closed
markusheiden opened this issue Mar 17, 2021 · 1 comment
Closed
Assignees
Labels
bug pubsub GCP PubSub

Comments

@markusheiden
Copy link

markusheiden commented Mar 17, 2021

Describe the bug
When using com.google.cloud:spring-cloud-gcp-starter-bus-pubsub on the classpath and disable it in the application.yml via

spring:
  cloud:
    gcp:
      core.enabled: true
      pubsub.enabled: true

the startup fails with Parameter 0 of method pubSubChannelProvisioner in com.google.cloud.spring.stream.binder.pubsub.config.PubSubBinderConfiguration required a bean of type 'com.google.cloud.spring.pubsub.PubSubAdmin' that could not be found.

@markusheiden markusheiden changed the title PubSubBinderConfiguration is not disable when PubSub is disabled PubSubBinderConfiguration is not disabled when PubSub is disabled Mar 17, 2021
@ttomsu ttomsu self-assigned this Mar 17, 2021
@ttomsu ttomsu added bug pubsub GCP PubSub labels Mar 17, 2021
@ttomsu
Copy link

ttomsu commented Mar 17, 2021

Yep, this looks like an issue. I'll fix it in the new repo and backport it here. Thanks for finding and filing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug pubsub GCP PubSub
Development

No branches or pull requests

3 participants