Skip to content
This repository has been archived by the owner on Feb 23, 2023. It is now read-only.

Review http and https related hints #1117

Closed
joshlong opened this issue Sep 30, 2021 · 3 comments
Closed

Review http and https related hints #1117

joshlong opened this issue Sep 30, 2021 · 3 comments
Assignees
@sdeleuze
Labels
type: task A general task

Comments

@joshlong
Copy link
Contributor

@NativeHint(options = "--enable-url-protocols=http,https")
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Sep 30, 2021
@joshlong
Copy link
Contributor Author

Ideally, they'd be enabled by default for everything, always. I just ran Liquibase (with no HTTP server) and it needed HTTP for schema resolution.

@sdeleuze sdeleuze changed the title please add a hint so that when Spring Security is on the classpath, we automatically get HTTP and HTTPS support Review http and https related hints Oct 1, 2021
@sdeleuze
Copy link
Contributor

sdeleuze commented Oct 1, 2021

I don't think we should add that by default, especially https which is impacting significantly the memory footprint, but we can add flags with the right granular hints. We could decide to add https by default for WebClient and RestTemplate. For server, I am not sure since servers can be behind an http server which will take car of https.

@sdeleuze sdeleuze added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 1, 2021
@sdeleuze sdeleuze added this to the 0.11.x milestone Oct 1, 2021
@sdeleuze sdeleuze self-assigned this Oct 4, 2021
@sdeleuze sdeleuze modified the milestones: 0.11.x, 0.11.0-M2 Oct 4, 2021
@sdeleuze
Copy link
Contributor

I think with #1185 we are now reasonably fine. Liquibase support will be added via #620.

@sdeleuze sdeleuze removed this from the 0.11.0-M2 milestone Oct 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sdeleuze sdeleuze

Labels
type: task A general task
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshlong @sdeleuze @spring-projects-issues