Keep end-of-line of maven wrapper mvnw to LF (linefeed)

[marcpa00]

Even on windows, mvnw is a bash shell script that needs to be in unix format to be correctly executed.

[artembilan]

Well, I have my Git on Windows configured like "Checkout CRLF - checkin LF".
And it works for any project the same way.
I don't think this is project related...
Otherwise you are going to have a burden to commit similar change to all the projects you would like to contribute to.

Closed as "Won't Fix"

[marcpa00]

The git settings is not the problem (I have same as you) : it is the combination of running windows and wanting to use "git bash" or any unix-like shell on windows to run mvnw. Running the batch file from "cmd.exe" is not a problem, it is running the bash shell script that fails.

For me, it is the same thing as specifying 'apps/' in the .gitignore file : it has to be done for every project.

If I do it for every project under spring-cloud-stream-app-starters, would it have more chance to be accepted ?

[artembilan]

I think there should be some configurations for that "git bash" on Windows as well.
Still it doesn't sound like belong to this or any other projects.

Not sure why you are pursuing Git related configuration in the project source...

[marcpa00]

With respect to git related configuration in the project source : when I checkout a project and i see a maven or gradle wrapper in it, I expect to be able to build it with my choice of tools, i.e. bash on windows in my case. But, as the mvnw is encoded with CRLF, it does not work and there is no configuration for that in "git bash".

It is about having the lowest barrier to entry for potential contributor.

But it is your call, I won't bother with other pr regarding this issue.