spring.config.name has not effect when set in bootstrap.properties

[ryanjbaxter]

In Greenwich and prior releases setting spring.config.name in bootstrap.[yml | properties] would cause boot to look for a configuration file equal to spring.config.name. This does not work in master (Hoxton). To reproduce add a file called confignamebootstrap.properties to /test/resources and place the following properties in the file

spring.application.name:main
spring.config.name:plain

Then in BootstrapConfigurationTests add the following test

	@Test
	public void configNameInBootstrap() {
		System.setProperty("expected.name", "main");
		this.context = new SpringApplicationBuilder().web(WebApplicationType.NONE)
				.properties("spring.cloud.bootstrap.name:confignamebootstrap")
				.sources(BareConfiguration.class).run();
		then(this.context.getEnvironment().getProperty("spring.application.name"))
				.isEqualTo("app");
		// The parent is called "main" because spring.application.name is specified in
		// other.properties (the bootstrap properties)
		then(this.context.getParent().getEnvironment()
				.getProperty("spring.application.name")).isEqualTo("main");
		// The bootstrap context has the same "bootstrap" property source
		then(((ConfigurableEnvironment) this.context.getParent().getEnvironment())
				.getPropertySources().get("bootstrap"))
				.isEqualTo(this.context.getEnvironment().getPropertySources()
						.get("bootstrap"));
		then(this.context.getId()).isEqualTo("main-1");
	}

This test passes in 2.1.x but fails in master.

[ryanjbaxter]

Had to ignore this test due to this bug
spring-cloud/spring-cloud-core-tests@ce2d478

[ryanjbaxter]

Also wondering if this might be related at all f5e1bfd#diff-120f54fb381ae7aae2ba6c97156a8199

[ryanjbaxter]

I opened an issue in boot that I think traced the root cause of the problem spring-projects/spring-boot#17011

[ryanjbaxter]

The issues in boot have been addressed, so I am closing this issue.