Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/features endpoint relies on metadata from manifest that might not be available #1698

Open
dsyer opened this issue Sep 8, 2020 · 1 comment
Labels

Comments

@dsyer
Copy link
Contributor

dsyer commented Sep 8, 2020

I guess this will require a judgement call. The problem is that FeaturesEndpoint relies on this snippet:

	private void addFeature(Features features, NamedFeature feature) {
		Class<?> type = feature.getType();
		features.getEnabled()
				.add(new Feature(feature.getName(), type.getCanonicalName(),
						type.getPackage().getImplementationVersion(),
						type.getPackage().getImplementationVendor()));
	}

and the package information from the manifest is not available in general (in particular not in a GraalVM native image). It would be ideal to provide a fallback. Or just omit it if not known?

@spencergibb
Copy link
Member

I'd say omit if not known.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants