-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot read properties off Secrets Manager when marked for deletion #2346
Comments
So we just need to add Lines 158 to 161 in 2215998
Interested in submitting a RP with a test? |
I'd love to but I cannot compile this project. The
|
I've managed to run tests inside IntelliJ Idea at least. However I'm getting 403 when trying to push my local branch.
|
You should be pushing to your own fork and then submitting a PR from that fork |
PR for 4.0.x branch submitted #2350. Is it going to be automatically synchronized with the main branch once approved or do I have to create one for the main branch (Spring Cloud Config 4.1) as well? |
Yup I merged it forward, thanks! |
AwsSecretsManagerEnvironmentRepository
reads secrets asWhen secret does not exist it throws
ResourceNotFoundException
which is handled bycatch
block. However when secret is marked for deletion it throwsInvalidRequestException
which is not handled and the whole request to Config Sever fails.The text was updated successfully, but these errors were encountered: