New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After upgrading spring-cloud-config-client from 4.0.2 to 4.1.0 and Spring Boot from 3.1.5 to 3.2.0 properties from application.yml are missing #2376
Comments
There are some changes we made which effect when I think this PR would actually give you the functionality you need. Then you could do something like
If you could build my branch and test this out using Spring Cloud 2022.0.5-SNAPSHOT that would go a long ways to making sure that PR addresses your use case as well. |
@ryanjbaxter , |
Here is a sample I used to confirm things worked...maybe I am not doing the same thing. |
@ryanjbaxter , thank you for the demo. it worked on my side, too. I'm trying to set all the dependencies as in your project. |
No that shouldnt matter |
If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed. |
Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue. |
I found how to reproduce the issue in your Demo. Add to your test class DemoApplicationTests
Than you will see that the default value was returned instead of value from application.properties. |
When you add the |
Is it expected behaviour? Earlier in spring-cloud-config-client 4.0.2 and Spring Boot 3.1.5 everything worked anyway. |
The change is merged into 4.1.x at this point. Is this the expected behavior for the |
I created an issue for spring-boot: spring-projects/spring-boot#39940 |
@ryanjbaxter , |
The current plan is to have a release on March 26th https://github.com/spring-cloud/spring-cloud-release/milestones |
If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed. |
Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue. |
Initially I created an issue for spring-boot but their team asked to create it to spring-cloud.
spring-projects/spring-boot#39238
We upgraded our spring-boot-starter-web library from 3.5.1 to 3.2.0 version , spring-cloud-config-client from 4.0.2 to 4.1.0
and some functional stopped working.
We have a spring.factories file where we register
org.springframework.boot.BootstrapRegistryInitializer=com.my.configuration.CustomBootstrapper
In CustomBootstrapper we have custom call for config-server data loading:
(3) In class CustomDataLoader we try to get custom property from application.yml :
Unfortunately we got null in propertyBindResult. But previously it returned the value set in application.yml.
The text was updated successfully, but these errors were encountered: