Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent terminology for Heroku App ID #53

Closed
chrylis opened this issue Jul 17, 2014 · 2 comments
Closed

Inconsistent terminology for Heroku App ID #53

chrylis opened this issue Jul 17, 2014 · 2 comments

Comments

@chrylis
Copy link
Contributor

chrylis commented Jul 17, 2014

The current code uses SPRING_CLOUD_APP_NAME to identify an application name from within Heroku, but the API refers to the value in question as appId(). Keep as a wart or breaking-change to a consistent SPRING_CLOUD_APP_ID?

Note that the way I determine whether the local connector should activate is to look for spring.cloud.appId; if we extend that to an environment scan, the values would semantically mean the same thing, but the current logic would get a false-positive on the local connector, so that would need to be addressed somehow.

@ramnivas
Copy link
Contributor

Heroku connector isn't as widely used so far, so making this change (deprecate SPRING_CLOUD_APP_NAME with a runtime warning) in favor of SPRING_CLOUD_APP_ID is fine. If you can make a PR, that will be great. Else, I will handle this shortly.

@scottfrederick
Copy link
Collaborator

Since this library has been released for a while now and is in wider use, let's not implement this breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants