Use buildpack in docs #312
Conversation
| @@ -69,7 +69,7 @@ deployment to fail | |||
|
|
|||
| [subs=attributes] | |||
| ``` | |||
| cf push dataflow-server -m 2G -k 2G --no-start -p spring-cloud-dataflow-server-cloudfoundry-{project-version}.jar | |||
| cf push dataflow-server -b java_buildpack_offline -m 2G -k 2G --no-start -p spring-cloud-dataflow-server-cloudfoundry-{project-version}.jar | |||
There was a problem hiding this comment.
cf buildpacks doesn't list java_buildpack_offline as a known buildpack. May be it is just for the CF environment I target to. Also, not sure which buildpacks get added by default for any CF environment. May be we can use the one (java_buildpack ?) that comes from default?
There was a problem hiding this comment.
That was one of my concern, that names are not consistent.
Tested on our GCP env.
Not sure there is one "that comes from default" actually... Maybe this is not worth the trouble after all. WDYT @markpollack ?
There was a problem hiding this comment.
I believe -b java_buildpack is the default value in a PCF install. Let's align with that default value for the docs.
There was a problem hiding this comment.
ok, merging the PR with the change to use java_buildpack
|
Rebased and merged as 6ddea7e |
Fixes #308