Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show deployment properties from previous task execution in the Parameters field on task launch page #1387

Closed
cppwfs opened this issue Feb 25, 2020 · 4 comments · Fixed by #1400
Assignees
Labels
type/enhancement Is an enhancement request

Comments

@cppwfs
Copy link

cppwfs commented Feb 25, 2020

We have a scenario as described in issue spring-cloud/spring-cloud-dataflow#3773 where users need to know what properties they will be using when they launch a task. Hence we need to show them the deployment properties from the previous execution in the Parameters field on the task launch page. The deploymentProperties can be obtained by calling the tasks/executions/<task-execution-id> using the task-execution-id field from the definitions request made when going to the task launch page.
Make sure that if their is redacted data i.e. a value of ****** that we do not resend that data.

@oodamien
Copy link
Member

To achieve this, we have to make 2 calls:

  • Get the latest execution of a task
  • Then get the details of the task execution

@oodamien oodamien added type/enhancement Is an enhancement request and removed type/bug Is a bug report labels Feb 27, 2020
@sabbyanandan
Copy link
Contributor

@cppwfs: Do you have any recommendations? Perhaps we could combine them in the same call instead?

@cppwfs
Copy link
Author

cppwfs commented Mar 9, 2020

@sabbyanandan We would want to create a new endpoint on SCDF vs updating the current one. I'd say a 3 pointer. Do you want me to add a story?

@sabbyanandan
Copy link
Contributor

For now, we will make 2 calls to bring the relevant info on the task-launch details page. This is done on-demand, and only applicable for when a task is re-launched, so the performance may not be a paramount concern. Besides that, we don't support bulk launches (so no need to retrieve this info in bulk), and this doesn't apply at the time of scheduling, as well.

Long term, though, we can add a new API: spring-cloud/spring-cloud-dataflow#3845.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Is an enhancement request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants